Fix shellcheck failures and switch to new shellcheck gh action

* 0efce36 (  11 seconds ago Paul Irish) nevermind indent. fails without any output lol
* 5769150 (   2 minutes ago Paul Irish) check indent
* 5677749 (   3 minutes ago Paul Irish) fish install
* 297a2df (   4 minutes ago Paul Irish) fish too
* 39bc4c4 (   9 minutes ago Paul Irish) diff action
* caafe8a (  16 minutes ago Paul Irish) shellcheck more
* ffa8869 (  27 minutes ago Paul Irish) specify shells for these dummies
* 3b70e81 (  33 minutes ago Paul Irish) fix shellcheck errors. and update git completion

Author: paulirish

.aliases

@@ -1,3 +1,5 @@
+#!/bin/bash
+
 # Easier navigation: .., ..., ~ and -
 alias ..="cd .."
 alias cd..="cd .."

.bash_profile

@@ -1,8 +1,8 @@
-
+# shellcheck shell=bash
 
 # PATH setup via ~/.paths
 setupPATH() {
-    # Credit to https://github.com/davidaurelio/dotfiles/blob/main/.profile for the technique
+    # Credit to https://github.com/davidaurelio/dotfiles/blob/main/.profile for the technique of resolving $variables
     while read -r P; do
     P=`eval echo $P`
     if [ -d "$P" ]; then

.bash_prompt

@@ -1,3 +1,5 @@
+#!/bin/bash
+
 # This prompt inspired by gf3, sindresorhus, alrra, and mathiasbynens.
 # but customized to me. <3
 

.bashrc

@@ -1,5 +1,4 @@
-
-
+# shellcheck shell=bash
 
 [ -n "$PS1" ] && source ~/.bash_profile
 

.exports

@@ -1,3 +1,5 @@
+#!/bin/bash
+
 # file is shared between bash and fish
 # todo: place these near the thematically related stuff. grouping as .exports is dumb.
 

.functions

@@ -20,7 +20,7 @@ cdf() {  # short for cdfinder
 # Use `which` along with symlink resolving
 whichlink() {
 	# This dopeass conditional stolen from sheerun's dotfiles
-	$(type -p greadlink readlink | head -1) -f $(which $@)
+	$(type -p greadlink readlink | head -1) -f $(which "$@")
 }