SWEEP: Replace BCL Dictionary<TKey,TValue> with JCG.Dictionary<TKey,TValue> (apache#1273) (apache#1287)

* SWEEP: Replace BCL Dictionary<TKey,TValue> with JCG.Dictionary<TKey,TValue> (apache#1273)

Replaces System.Collections.Generic.Dictionary<TKey, TValue> with
J2N.Collections.Generic.Dictionary<TKey, TValue> across all Java-derived
sources, using the alias JCG.Dictionary<TKey, TValue>.

J2N's Dictionary supports JDK HashMap semantics (null keys, removal during
enumeration, ReadOnlySpan<char> alternate lookup, structural equality and
formatting), which the BCL type lacks. Using BCL Dictionary in Java-derived
code was potentially masking bugs in extensions with low test coverage.

Exclusions per the issue:
- Lucene.Net.CodeAnalysis.* projects
- Lucene.Net.Replicator.AspNetCore
- lucene-cli + Lucene.Net.Tests.Cli
- Lucene.Net.Tests.TestFramework.{DependencyInjection,NUnitExtensions}
- Support folders and Lucene.Net.Support namespace
  (except TagSoup and Sax under Lucene.Net.Benchmark/Support, which
  are explicitly in scope per the issue)

Public API surface continues to expose IDictionary<TKey, TValue>; this is
not a binary-breaking change.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* Commenting out using statements that were added to cover code that is currently commented out

---------

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: vwilson

src/Lucene.Net.Analysis.Common/Analysis/CharFilter/HTMLStripCharFilter.cs

@@ -11,6 +11,7 @@
 using System.Globalization;
 using System.IO;
 using Integer = J2N.Numerics.Int32;
+using JCG = J2N.Collections.Generic;
 
 namespace Lucene.Net.Analysis.CharFilters
 {
@@ -30679,7 +30680,7 @@ private static int ZzUnpackAttribute(string packed, int offset, int[] result)
         /// user code:
         /// </summary>
         private static readonly IDictionary<string, string> upperCaseVariantsAccepted
-            = new Dictionary<string, string>()
+            = new JCG.Dictionary<string, string>()
             {
                 {"quot", "QUOT"},
                 {"copy", "COPY" },

src/Lucene.Net.Analysis.Common/Analysis/CharFilter/NormalizeCharMap.cs

@@ -36,7 +36,7 @@ namespace Lucene.Net.Analysis.CharFilters
     public class NormalizeCharMap
     {
         internal readonly FST<CharsRef> map;
-        internal readonly IDictionary<char?, FST.Arc<CharsRef>> cachedRootArcs = new Dictionary<char?, FST.Arc<CharsRef>>();
+        internal readonly IDictionary<char?, FST.Arc<CharsRef>> cachedRootArcs = new JCG.Dictionary<char?, FST.Arc<CharsRef>>();
 
         // Use the builder to create:
         private NormalizeCharMap(FST<CharsRef> map)

src/Lucene.Net.Analysis.Common/Analysis/Compound/Hyphenation/PatternParser.cs

@@ -195,7 +195,7 @@ private static XmlReaderSettings GetXmlReaderSettings() // LUCENENET: CA1822: Ma
 
         private static IDictionary<string, string> GetAttributes(XmlReader node) // LUCENENET: CA1822: Mark members as static
         {
-            var result = new Dictionary<string, string>();
+            var result = new JCG.Dictionary<string, string>();
             if (node.HasAttributes)
             {
                 for (int i = 0; i < node.AttributeCount; i++)

src/Lucene.Net.Analysis.Common/Analysis/Core/LowerCaseTokenizerFactory.cs

@@ -4,6 +4,7 @@
 using System;
 using System.Collections.Generic;
 using System.IO;
+using JCG = J2N.Collections.Generic;
 
 namespace Lucene.Net.Analysis.Core
 {
@@ -55,7 +56,7 @@ public override Tokenizer Create(AttributeFactory factory, TextReader input)
 
         public virtual AbstractAnalysisFactory GetMultiTermComponent()
         {
-            return new LowerCaseFilterFactory(new Dictionary<string, string>(OriginalArgs));
+            return new LowerCaseFilterFactory(new JCG.Dictionary<string, string>(OriginalArgs));
         }
     }
 }

src/Lucene.Net.Analysis.Common/Analysis/Hunspell/Dictionary.cs

@@ -725,7 +725,7 @@ internal static string GetDictionaryEncoding(Stream affix)
         internal static readonly IDictionary<string, string> CHARSET_ALIASES = LoadCharsetAliases();
         private static IDictionary<string, string> LoadCharsetAliases() // LUCENENET: Avoid static constructors (see https://github.com/apache/lucenenet/pull/224#issuecomment-469284006)
         {
-            return Collections.AsReadOnly(new Dictionary<string, string>
+            return Collections.AsReadOnly(new JCG.Dictionary<string, string>
             {
                 ["microsoft-cp1251"] = "windows-1251",
                 ["TIS620-2533"] = "TIS-620"

src/Lucene.Net.Analysis.Common/Analysis/Pt/RSLPStemmerBase.cs

@@ -284,7 +284,7 @@ protected static IDictionary<string, Step> Parse(Type clazz, string resource)
         {
             try
             {
-                IDictionary<string, Step> steps = new Dictionary<string, Step>();
+                IDictionary<string, Step> steps = new JCG.Dictionary<string, Step>();
 
                 using (TextReader r = IOUtils.GetDecodingReader(clazz, resource, Encoding.UTF8))
                 {

src/Lucene.Net.Analysis.Common/Analysis/Query/QueryAutoStopWordAnalyzer.cs

@@ -41,7 +41,7 @@ namespace Lucene.Net.Analysis.Query
     public sealed class QueryAutoStopWordAnalyzer : AnalyzerWrapper
     {
         private readonly Analyzer @delegate;
-        private readonly IDictionary<string, ISet<string>> stopWordsPerField = new Dictionary<string, ISet<string>>();
+        private readonly IDictionary<string, ISet<string>> stopWordsPerField = new JCG.Dictionary<string, ISet<string>>();
         //The default maximum percentage (40%) of index documents which
         //can contain a term, after which the term is considered to be a stop word.
         public const float defaultMaxDocFreqPercent = 0.4f;

src/Lucene.Net.Analysis.Common/Analysis/Synonym/FSTSynonymFilterFactory.cs

@@ -35,7 +35,7 @@ internal sealed class FSTSynonymFilterFactory : TokenFilterFactory, IResourceLoa
         private readonly string synonyms;
         private readonly string format;
         private readonly bool expand;
-        private readonly IDictionary<string, string> tokArgs = new Dictionary<string, string>();
+        private readonly IDictionary<string, string> tokArgs = new JCG.Dictionary<string, string>();
 
         private SynonymMap map;
 

src/Lucene.Net.Analysis.Common/Analysis/Synonym/SlowSynonymFilterFactory.cs

@@ -46,7 +46,7 @@ internal sealed class SlowSynonymFilterFactory : TokenFilterFactory, IResourceLo
         private readonly bool ignoreCase;
         private readonly bool expand;
         private readonly string tf;
-        private readonly IDictionary<string, string> tokArgs = new Dictionary<string, string>();
+        private readonly IDictionary<string, string> tokArgs = new JCG.Dictionary<string, string>();
 
         // LUCENENET: Optimized by pre-comiling regex and lazy-loading
         private class Holder

src/Lucene.Net.Analysis.Common/Analysis/Synonym/SynonymFilterFactory.cs

@@ -3,6 +3,7 @@
 using Lucene.Net.Util;
 using System;
 using System.Collections.Generic;
+using JCG = J2N.Collections.Generic;
 
 namespace Lucene.Net.Analysis.Synonym
 {
@@ -67,7 +68,7 @@ public SynonymFilterFactory(IDictionary<string, string> args)
 #pragma warning disable 612, 618
             if (m_luceneMatchVersion.OnOrAfter(Lucene.Net.Util.LuceneVersion.LUCENE_34))
             {
-                delegator = new FSTSynonymFilterFactory(new Dictionary<string, string>(OriginalArgs));
+                delegator = new FSTSynonymFilterFactory(new JCG.Dictionary<string, string>(OriginalArgs));
             }
 #pragma warning restore 612, 618
             else
@@ -79,7 +80,7 @@ public SynonymFilterFactory(IDictionary<string, string> args)
                     throw new ArgumentException("You must specify luceneMatchVersion >= 3.4 to use alternate synonyms formats");
                 }
 #pragma warning disable 612, 618
-                delegator = new SlowSynonymFilterFactory(new Dictionary<string, string>(OriginalArgs));
+                delegator = new SlowSynonymFilterFactory(new JCG.Dictionary<string, string>(OriginalArgs));
 #pragma warning restore 612, 618
             }
         }