Respond with error 400 on missing attribute for CreatePermission and ChannelBind

Author: paullouisageneau

src/server.c

@@ -985,7 +985,9 @@ int server_process_turn_create_permission(juice_server_t *server, const stun_mes
 	// are invalid, then a 400 (Bad Request) error is returned.
 	if (!msg->peers_size) {
 		JLOG_WARN("Missing peer address in TURN CreatePermission request");
-		return -1;
+		return server_answer_stun_error(server, msg->transaction_id, src, msg->msg_method,
+		                                400, // Bad request
+		                                credentials);
 	}
 
 	server_turn_alloc_t *alloc = find_allocation(server->allocs, server->allocs_count, src, false);
@@ -1030,11 +1032,15 @@ int server_process_turn_channel_bind(juice_server_t *server, const stun_message_
 
 	if (!msg->peers_size) {
 		JLOG_WARN("Missing peer address in TURN ChannelBind request");
-		return -1;
+		return server_answer_stun_error(server, msg->transaction_id, src, msg->msg_method,
+		                                400, // Bad request
+		                                credentials);
 	}
 	if (!msg->channel_number) {
 		JLOG_WARN("Missing channel number in TURN ChannelBind request");
-		return -1;
+		return server_answer_stun_error(server, msg->transaction_id, src, msg->msg_method,
+		                                400, // Bad request
+		                                credentials);
 	}
 
 	server_turn_alloc_t *alloc = find_allocation(server->allocs, server->allocs_count, src, false);