fix(logbook): resolve duplicated comments

Author: derangula123

scilog/src/app/logbook/core/add-content.service.ts

@@ -1,20 +1,20 @@
 import { Injectable } from '@angular/core';
-import { BehaviorSubject } from 'rxjs';
+import { Subject } from 'rxjs';
 import { ChangeStreamNotification } from './changestreamnotification.model';
 
 @Injectable({
-  providedIn: 'root',
+  providedIn: 'root'
 })
 export class AddContentService {
-  msg: ChangeStreamNotification = {};
-  private messageSource = new BehaviorSubject(this.msg);
-  currentMessage = this.messageSource.asObservable();
-  constructor() {}
+
+  private messageSource = new Subject<ChangeStreamNotification>();
+
+  currentMessage$ = this.messageSource.asObservable();
+
+  constructor() { }
 
   changeMessage(message: ChangeStreamNotification) {
     this.messageSource.next(message);
-    console.log(this.msg);
-    this.messageSource.next(null);
-    console.log(this.msg);
   }
 }
+

scilog/src/app/logbook/core/add-content/add-content.component.ts

@@ -102,7 +102,7 @@ export class AddContentComponent implements OnInit, OnDestroy {
   ngOnInit(): void {
     this.setupComponent();
     this.subscriptions.push(
-      this.dataService.currentMessage.subscribe((message) => {
+      this.dataService.currentMessage$.subscribe((message) => {
         console.log(message);
         if (message != null) {
           // this.message = message;

scilog/src/app/logbook/widgets/logbook-item/logbook-item.component.ts

@@ -319,36 +319,43 @@ export class LogbookItemComponent implements OnInit, AfterViewInit, OnDestroy {
   }
 
   startNotificationManager() {
-    if (typeof this.config != 'undefined') {
-      if (this.changeStreamSubscriptions.length > 0) {
-        this.changeStreamSubscriptions.forEach((sub) => sub.unsubscribe());
-      }
-      let logbooks = [this.config.filter.targetId, ...this.config.filter?.additionalLogbooks];
-      console.log('Subscribing to the following logbooks: ', logbooks);
-      logbooks.forEach((log) => {
-        this.changeStreamSubscriptions.push(
-          this.notificationService.getNotification(log, this.config).subscribe((notification) => {
-            console.log(notification);
-            this.notifications.push(notification);
-            this.parseNotification(notification);
-          }),
-        );
-      });
+    if (!this.config) return; // Clean old changeStream subscriptions
+    if (this.changeStreamSubscriptions.length > 0) {
+      this.changeStreamSubscriptions.forEach((s) => s.unsubscribe());
+      this.changeStreamSubscriptions = [];
+    }
+    const logbooks = [
+      this.config.filter.targetId,
+      ...(this.config.filter?.additionalLogbooks ?? []),
+    ];
 
-      if (this.dataService == null) {
-        this.dataService = this.data.currentMessage.subscribe((message) => {
-          // console.log(message);
-          this.message = message;
-          if (message != null && Object.keys(this.message).length != 0) {
-            // console.log(this.message);
-            this.submitContent(message);
-            this.message = null;
-          }
+    logbooks.forEach((log) => {
+      const sub = this.notificationService
+        .getNotification(log, this.config)
+        .subscribe((notification) => {
+          this.parseNotification(notification);
         });
-      }
+
+      this.changeStreamSubscriptions.push(sub);
+    });
+
+    //  ALWAYS unsubscribe previous message subscription
+    if (this.dataService) {
+      this.dataService.unsubscribe();
+      this.dataService = null;
     }
+
+    this.dataService = this.data.currentMessage$.subscribe((message) => {
+      if (!message) return;
+
+      //  Only main widget should submit
+      if (this.configIndex !== 1) return;
+
+      this.submitContent(message);
+    });
   }
 
+
   async parseNotification(notification: ChangeStreamNotification) {
     switch (notification.operationType) {
       case 'update':