feedback

Author: jon-bell

app/course/[course_id]/manage/assignments/[assignment_id]/edit/page.tsx

@@ -99,11 +99,16 @@ export default function EditAssignment() {
         values.eval_config = undefined;
         values.allow_early = undefined;
         values.deadline_offset = undefined;
+        const reminderInterval = values.late_grading_reminder_interval_hours;
         values.late_grading_reminder_interval_hours = values.late_grading_reminders_enabled
-          ? (values.late_grading_reminder_interval_hours ?? 12)
+          ? typeof reminderInterval === "number" && Number.isFinite(reminderInterval)
+            ? reminderInterval
+            : 12
           : null;
-        values.late_grading_reply_to = values.late_grading_reply_to || null;
-        values.late_grading_cc_emails = values.late_grading_cc_emails || { emails: [] };
+        const replyTrimmed =
+          typeof values.late_grading_reply_to === "string" ? values.late_grading_reply_to.trim() : "";
+        values.late_grading_reply_to = replyTrimmed.length > 0 ? replyTrimmed : null;
+        values.late_grading_cc_emails = values.late_grading_cc_emails ?? { emails: [] };
         await form.refineCore.onFinish(values);
         await revalidateCourseDerivedCachesClient(Number.parseInt(course_id as string, 10));
         if (values.template_repo) {

app/course/[course_id]/manage/assignments/new/form.tsx

@@ -55,6 +55,15 @@ export type AssignmentFormValues = Assignment & {
   allow_early?: boolean | null;
 };
 
+/** Coerce number inputs so toggling visibility never leaves `NaN` in form state (NaN breaks `??` fallbacks). */
+const numberInputValueAs = (emptyFallback: number | null) => (value: unknown) => {
+  if (value === "" || value === null || value === undefined) {
+    return emptyFallback;
+  }
+  const n = Number(value);
+  return Number.isFinite(n) ? n : emptyFallback;
+};
+
 const normalizeCcEmails = (value: unknown): GradingCcEmails => {
   if (value && typeof value === "object" && "emails" in value) {
     const emails = (value as { emails?: unknown }).emails;
@@ -598,7 +607,8 @@ function GradingAutomationSubform({
   } = useList<GradingAssignmentDefaultProfile>({
     resource: "grading_assignment_default_profiles",
     filters: [{ field: "class_id", operator: "eq", value: courseId }],
-    pagination: { pageSize: 200 }
+    pagination: { pageSize: 200 },
+    queryOptions: { enabled: Number.isFinite(courseId) }
   });
   const profiles = useMemo(() => profileData?.data ?? [], [profileData?.data]);
   const profileMap = useMemo(
@@ -748,7 +758,7 @@ function GradingAutomationSubform({
                   {...register("auto_assign_review_due_hours", {
                     required: autoAssignAtDeadline ? "This is required when auto assign is enabled" : false,
                     min: { value: 0, message: "Must be at least 0 hours" },
-                    valueAsNumber: true
+                    setValueAs: numberInputValueAs(72)
                   })}
                 />
               </Field>
@@ -789,7 +799,7 @@ function GradingAutomationSubform({
                   {...register("late_grading_reminder_interval_hours", {
                     required: remindersEnabled ? "This is required when reminders are enabled" : false,
                     min: { value: 1, message: "Must be at least 1 hour" },
-                    valueAsNumber: true
+                    setValueAs: numberInputValueAs(null)
                   })}
                 />
               </Field>

app/course/[course_id]/manage/course/grading-assignment-defaults/page.tsx

@@ -3,6 +3,7 @@
 import { Button } from "@/components/ui/button";
 import { Field } from "@/components/ui/field";
 import { toaster, Toaster } from "@/components/ui/toaster";
+import { createClient } from "@/utils/supabase/client";
 import type { GradingAssignmentDefaultProfile } from "@/utils/supabase/DatabaseTypes";
 import {
   Box,
@@ -77,6 +78,14 @@ const normalizeCcEmails = (value: unknown): GradingCcEmails => {
 
 const toCcText = (value: unknown): string => normalizeCcEmails(value).emails.join(", ");
 
+const numberInputValueAs = (emptyFallback: number | null) => (value: unknown) => {
+  if (value === "" || value === null || value === undefined) {
+    return emptyFallback;
+  }
+  const n = Number(value);
+  return Number.isFinite(n) ? n : emptyFallback;
+};
+
 export default function GradingAssignmentDefaultsPage() {
   const { course_id } = useParams();
   const classId = Number(course_id);
@@ -182,7 +191,26 @@ export default function GradingAssignmentDefaultsPage() {
   });
 
   const handleDelete = async (id: number) => {
-    const confirmed = window.confirm("Delete this grading default profile?");
+    const supabase = createClient();
+    const { count, error: countError } = await supabase
+      .from("assignments")
+      .select("*", { count: "exact", head: true })
+      .eq("grading_default_profile_id", id);
+
+    if (countError) {
+      toaster.error({
+        title: "Could not check assignment references",
+        description: countError.message
+      });
+      return;
+    }
+
+    const refCount = count ?? 0;
+    const refNote =
+      refCount > 0
+        ? ` ${refCount} assignment${refCount === 1 ? "" : "s"} reference this profile; those assignments will show no saved profile after deletion.`
+        : "";
+    const confirmed = window.confirm(`Delete this grading default profile?${refNote}`);
     if (!confirmed) {
       return;
     }
@@ -287,8 +315,8 @@ export default function GradingAssignmentDefaultsPage() {
                         <Input
                           type="number"
                           {...register("auto_assign_review_due_hours", {
-                            valueAsNumber: true,
-                            min: { value: 0, message: "Must be at least 0 hours" }
+                            min: { value: 0, message: "Must be at least 0 hours" },
+                            setValueAs: numberInputValueAs(72)
                           })}
                         />
                       </Field>
@@ -326,8 +354,8 @@ export default function GradingAssignmentDefaultsPage() {
                         <Input
                           type="number"
                           {...register("late_grading_reminder_interval_hours", {
-                            valueAsNumber: true,
-                            min: { value: 1, message: "Must be at least 1 hour" }
+                            min: { value: 1, message: "Must be at least 1 hour" },
+                            setValueAs: numberInputValueAs(null)
                           })}
                         />
                       </Field>