customer_name when the owner's name is not the name of the customer

[rodreegez]

Hey, so in the app I'm working on, the "owner" of the Pay::Customer object is Team. In this case, teams have names - typically either a company name or a department name, but not the name of a person.

I'm using Stripe Checkout, and Pay is able to send along the name of the customer for me. My problem is that it does this by first checking if the object responds to name and if not checking if it can form a string by combining first_name and last_name. Because my team responds to name I get the team name in Stripe Checkout, which in this case is incorrect.

I get the correct email because my Team model delegates email to the appropriate user on the Team. I'm trying to do something similar for name, but obviously I need Team to respond to name with the name of the Team. Team doesn't, in this case, need to respond to email so email can be delegated but I guess Team could feasibly have an email attribute, and that would raise the same issue.

I considered updating the customer_name method linked to above to first check for another attribute, e.g. billing_customer_name or customer_name_on_card or something like that. This would allow me to delegate that method in the same way that I'm currently delegating the email attribute, but that seems unsatisfactory for 2 reasons:

1. It exacerbates the implicit order of precidence when deciding what the name should be, and
2. It doesn't really change the fact that the thing the billing is attached to isn't a user.

I think a better solution would be to optionally allow injecting name, and probably email as well, however I look into doing this, I think it always comes back to add columns to the pay_customers table, whcih I suspect we don't really want to do.

So I guess my question is, how can I inject a name other than owner#name?

[rodreegez]

One option might be to first check if the model responds to e.g. pay_customer_name and pay_customer_email before falling back to the current implementation?

[rodreegez]

I opened a PR to this effect here: #428

Not married to it. Any thoughts? Next step would be to do something similar for email, which would require making it a proper method rather than a delegated attribute and doing the same trick of checking for owner.pay_email before falling back to owner.email. WDYT?