chore: linting fixes

Author: austinzani

src/.DS_Store

@@ -1,4 +1,5 @@
 // noinspection JSUnusedGlobalSymbols
+// eslint-disable no-unused-vars
 
 import { defaultElementIds, ElementTypes, MERCHANT_FEE, SERVICE_FEE } from './data';
 
@@ -108,7 +109,7 @@ export interface TokenizedPaymentMethodObject {
   brand: string;
   expiration: string;
   payment_type: 'card' | 'ach';
-  metadata: { [keys: string | number]: string | number | boolean };
+  metadata: Record<string | number, string | number | boolean>;
 }
 
 export interface TokenizedPaymentMethodResponse {

src/common/pay_theory_types.ts

@@ -1,3 +1,6 @@
+/* eslint-disable no-unused-vars */
+/* eslint-disable no-empty-function */
+
 import PayTheoryHostedField from '../pay-theory-hosted-field';
 import common from '../../common';
 import {
@@ -87,7 +90,7 @@ class PayTheoryHostedFieldTransactional extends PayTheoryHostedField {
   protected _completed = false;
 
   // Used to track if the element was the one that was used when transact was called
-  protected _isTransactingElement: boolean = false;
+  protected _isTransactingElement = false;
 
   // Used to track if the element is ready to communicate with the transacting iframe
   protected _isReady = false;
@@ -249,30 +252,33 @@ class PayTheoryHostedFieldTransactional extends PayTheoryHostedField {
     }
   }
 
-  async connectedCallback() {
+  connectedCallback() {
     // Set up a listener for the hosted field to message saying it is ready for the pt-token to be sent
     this._removeHostTokenListener = common.handleHostedFieldMessage(
-      // @ts-ignore
       (event: { type: unknown; element: ElementTypes }) => {
         return (
           event.type === 'pt-static:pt_token_ready' &&
           this._transactingIFrameId.includes(event.element)
         );
       },
-      this.sendPtToken,
+      () => this.sendPtToken(),
     );
 
     this._removeFeeListener = common.handleHostedFieldMessage(
       (event: { type: unknown }) => event.type === 'pt-static:calculated_fee',
-      this.handleFeeMessage,
+      (message: {
+        type: string;
+        body: { fee: number; payment_type: string };
+        field: ElementTypes;
+      }) => this.handleFeeMessage(message),
     );
 
     this._removeFeeCalcReconnect = common.handleHostedFieldMessage(
       (event: { type: unknown }) => event.type === 'pt-static:fee_calc_reconnect',
-      this.handleFeeCalcReconnect,
+      (message: { type: string; field: ElementTypes }) => this.handleFeeCalcReconnect(message),
     );
 
-    await super.connectedCallback();
+    super.connectedCallback();
   }
 
   disconnectedCallback() {
@@ -286,7 +292,6 @@ class PayTheoryHostedFieldTransactional extends PayTheoryHostedField {
     data.fee_mode = data.fee_mode ?? this._feeMode ?? defaultFeeMode;
     data.metadata = data.metadata ?? this._metadata;
     this._isTransactingElement = true;
-    // @ts-ignore
     const response = await common.sendTransactingMessage(element, data.payTheoryData.billing_info);
     if (response.type === ERROR_STEP) {
       this._isTransactingElement = false;
@@ -334,7 +339,7 @@ class PayTheoryHostedFieldTransactional extends PayTheoryHostedField {
         common.hostedFieldsEndpoint,
       );
       const result = await this.resetToken();
-      if (result) {
+      if (result.type === ResponseMessageTypes.READY) {
         this._isTransactingElement = false;
         this.initialized = false;
         // Successfully sent the cancel message and reset the token
@@ -355,7 +360,6 @@ class PayTheoryHostedFieldTransactional extends PayTheoryHostedField {
   ): Promise<TokenizedPaymentMethodMessage | ErrorMessage> {
     this._isTransactingElement = true;
     this._initialized = true;
-    // @ts-ignore
     const response = await common.sendTransactingMessage(element, data.billingInfo);
     if (response.type === ERROR_STEP) {
       this._isTransactingElement = false;

src/components/pay-theory-hosted-field-transactional/index.ts

@@ -1,6 +1,8 @@
 /* global HTMLElement */
+/* eslint-disable no-unused-vars */
+
 import common from '../../common';
-//@ts-expect-error
+//@ts-expect-error - TS doesn't know about DOMPurify
 import DOMPurify from 'dompurify';
 import { ElementTypes } from '../../common/data';
 import { StyleObject } from '../../common/pay_theory_types';

src/components/pay-theory-hosted-field/index.ts

@@ -154,7 +154,6 @@ const findAchError = (processedElements: PayTheoryHostedField[]): string | false
     return false;
   }
 
-  // @ts-ignore
   achCheck.forEach(obj => {
     if (processedElements.reduce(obj.check, false) === false) {
       return obj.error;
@@ -213,7 +212,7 @@ const validatePhone = (phone: string) => {
   return stripped.length >= 5 && stripped.length <= 15;
 };
 
-type payorInfo = {
+interface payorInfo {
   same_as_billing?: boolean;
   email?: string;
   phone?: string;
@@ -227,7 +226,7 @@ type payorInfo = {
     postal_code?: string;
     country?: string;
   };
-};
+}
 
 const isValidPayorInfo = (payorInfo: payorInfo): ErrorResponse | null => {
   if (!validate(payorInfo, 'object')) {
@@ -268,7 +267,7 @@ const isValidPayorInfo = (payorInfo: payorInfo): ErrorResponse | null => {
 };
 
 const nullifyEmptyStrings = (params: object) => {
-  const newParams = JSON.parse(JSON.stringify(params));
+  const newParams: object = JSON.parse(JSON.stringify(params));
   Object.keys(newParams).forEach(key => {
     const value = newParams[key as keyof typeof newParams] as unknown;
     if (value === '') {
@@ -281,9 +280,9 @@ const nullifyEmptyStrings = (params: object) => {
   return newParams;
 };
 
-const formatPayorObject = (payorInfo: payorInfo): PayorInfo => {
+const formatPayorObject = (payorInfo: PayorInfo): PayorInfo => {
   // Make a deep copy of the payorInfo object
-  let payorCopy = JSON.parse(JSON.stringify(payorInfo));
+  let payorCopy: PayorInfo = JSON.parse(JSON.stringify(payorInfo));
   // Nullify unknown empty strings
   payorCopy = nullifyEmptyStrings(payorCopy);
   // Strip out unknown non-numeric characters from the phone number
@@ -480,7 +479,7 @@ const isValidHealthExpenseType = (healthExpenseType: unknown): ErrorResponse | n
   if (healthExpenseType === null || healthExpenseType === undefined) return null;
   if (!validate<string>(healthExpenseType, 'string')) {
     return handleTypedError(ErrorType.INVALID_PARAM, 'healthExpenseType must be a string');
-  } //@ts-expect-error
+  } //@ts-expect-error - healthExpenseType is a string and want to compare to all values of the enum which are also strings
   if (!Object.values(HealthExpenseType).includes(healthExpenseType)) {
     return handleTypedError(
       ErrorType.INVALID_PARAM,
@@ -529,7 +528,7 @@ const validTransactionParams = (
   error = isValidPayorInfo(payorInfo);
   if (error) return error;
   // validate the payorId
-  error = isValidPayorDetails(payorInfo, payTheoryData?.payor_id);
+  error = isValidPayorDetails(payorInfo, payTheoryData.payor_id);
   if (error) return error;
   // validate the fee mode
   error = isValidFeeMode(feeMode);
@@ -547,7 +546,7 @@ const validTransactionParams = (
   error = isValidHealthExpenseType(props.healthExpenseType);
   if (error) return error;
   // validate the fee
-  return isValidFeeAmount(payTheoryData?.fee);
+  return isValidFeeAmount(payTheoryData.fee);
 };
 
 const validQRSize = (size: unknown): ErrorResponse | null => {