chore: fixing linting issues for codacy

Author: austinzani

src/common/dom.ts

@@ -60,7 +60,7 @@ const processContainer = <
   elements: T,
   type: keyof T,
 ): processedElement<T, F> | string => {
-  const contained = document.getElementById(`${elements[type]}-tag-frame`);
+  const contained = document.getElementById(`${elements[type] as string}-tag-frame`);
   if (contained === null) {
     const frameType = webComponentMap[type as ElementTypes];
     const frame = addFrame(frameType, elements[type] as string) as F;

src/common/format.ts

@@ -60,12 +60,12 @@ export const parseInputParams = (
   const inputCopy = JSON.parse(JSON.stringify(inputParams)) as ModifiedTransactProps;
   inputCopy.payTheoryData = {
     account_code: inputParams.accountCode ?? (metadata['pay-theory-account-code'] as string),
-    billing_info: (inputParams as TransactProps).billingInfo as BillingInfo | undefined,
-    fee: (inputParams as TransactProps).fee as number | undefined,
-    invoice_id: invoiceId as string | undefined,
+    billing_info: (inputParams as TransactProps).billingInfo,
+    fee: (inputParams as TransactProps).fee,
+    invoice_id: invoiceId,
     payment_parameters:
       inputParams.paymentParameters ?? (metadata['payment-parameters-name'] as string),
-    payor_id: payorId as string | undefined,
+    payor_id: payorId,
     receipt_description:
       (inputParams as TransactProps).receiptDescription ??
       (metadata['pay-theory-receipt-description'] as string),

src/common/pay_theory_types.ts

@@ -142,7 +142,7 @@ export interface ErrorResponse {
 export interface TokenizeProps {
   payorInfo?: PayorInfo;
   payorId?: string;
-  metadata?: { [keys: string | number]: string | number | boolean };
+  metadata?: Record<string | number, string | number | boolean>;
   billingInfo?: BillingInfo;
 }
 
@@ -151,7 +151,7 @@ export interface TransactProps {
   payorInfo?: PayorInfo;
   billingInfo?: BillingInfo;
   payorId?: string;
-  metadata?: { [keys: string | number]: string | number | boolean };
+  metadata?: Record<string | number, string | number | boolean>;
   feeMode?: typeof MERCHANT_FEE | typeof SERVICE_FEE;
   fee?: number;
   confirmation?: boolean;

src/components/pay-theory-checkout-button/index.ts

@@ -20,10 +20,6 @@ class PayTheoryCheckoutButton extends HTMLElement {
   protected _buttonBarcode: string | undefined;
   protected _session: string | undefined;
 
-  constructor() {
-    super();
-  }
-
   defineButton() {
     // Creating the iFrame for the Button
     const buttonFrame = document.createElement('iframe');

src/components/pay-theory-checkout-qr/index.ts

@@ -14,10 +14,6 @@ class PayTheoryCheckoutQR extends HTMLElement {
   protected _clearSuccessListener: (() => void) | undefined;
   protected _clearErrorListener: (() => void) | undefined;
 
-  constructor() {
-    super();
-  }
-
   defineQR() {
     // Creating the iFrame for the Button
     const qrFrame = document.createElement('iframe');

src/field-set/payment-fields-v2.ts

@@ -235,7 +235,7 @@ const payTheoryFields = async (inputParams: PayTheoryPaymentFieldsInput) =>
       const result = initializeFields(inputParams, channel.port2);
       if (result) resolve(result);
     } else {
-      document.addEventListener('DOMContentLoaded', async () => {
+      document.addEventListener('DOMContentLoaded', () => {
         const result = initializeFields(inputParams, channel.port2);
         if (result) resolve(result);
       });

src/field-set/payment-qr.ts

@@ -18,8 +18,8 @@ export default async (inputParams: PayTheoryQRInput) => {
     ? modifiedCheckoutDetails.feeMode
     : common.defaultFeeMode;
   const { paymentName, callToAction, acceptedPaymentMethods } = modifiedCheckoutDetails;
-  let removeErrorListener = () => {};
-  let removeHostedErrorListener = () => {};
+  let removeErrorListener: (() => void) | null = null;
+  let removeHostedErrorListener: (() => void) | null = null;
   // Putting error listener on the window and hosted button so that it can catch errors while it readies the session
   if (onError) {
     removeErrorListener = common.errorObserver(onError);
@@ -47,8 +47,8 @@ export default async (inputParams: PayTheoryQRInput) => {
   // Adding logic to onReady to receive the session data for redirecting to the hosted checkout page
   const onReadyWrapper = () => {
     // Remove the error listener because we added it to the button iFrame and do not want it to be called twice
-    removeErrorListener();
-    removeHostedErrorListener();
+    if (removeErrorListener) removeErrorListener();
+    if (removeHostedErrorListener) removeHostedErrorListener();
     if (onReady) {
       onReady(true);
     }