chore: linting cleanup

Author: austinzani

src/common/observe.ts

@@ -1,4 +1,5 @@
-/* eslint-disable @typescript-eslint/no-unused-vars */
+/* eslint-disable no-unused-vars */
+
 import * as messaging from './message';
 import {
   CashBarcodeObject,

src/common/pay_theory_types.ts

@@ -222,10 +222,10 @@ export interface CheckoutDetails {
 export interface PayTheoryQRInput {
   apiKey: string;
   checkoutDetails: CheckoutDetails;
-  size: number;
-  onReady: (ready: true) => void;
-  onError: (error: string) => void;
-  onSuccess: (result: SuccessfulTransactionObject) => void;
+  size?: number;
+  onReady?: (ready: true) => void;
+  onError?: (error: string) => void;
+  onSuccess?: (result: SuccessfulTransactionObject) => void;
 }
 
 export interface ButtonStyle {
@@ -275,15 +275,15 @@ export interface StyleObject {
 }
 
 export interface Level3DataSummary {
-  tax_amt: number;
-  tax_ind: TaxIndicatorType;
-  purch_idfr: string;
-  order_num: string;
-  discnt_amt: number;
-  frght_amt: number;
-  duty_amt: number;
-  dest_postal_code: string;
-  prod_desc: string[];
+  tax_amt?: number;
+  tax_ind?: TaxIndicatorType;
+  purch_idfr?: string;
+  order_num?: string;
+  discnt_amt?: number;
+  frght_amt?: number;
+  duty_amt?: number;
+  dest_postal_code?: string;
+  prod_desc?: string[];
 }
 
 export enum TaxIndicatorType {

src/components/pay-theory-checkout-button/index.ts

@@ -1,4 +1,6 @@
 /* global HTMLElement */
+/* eslint-disable no-unused-vars */
+
 import common from '../../common';
 import { SuccessfulTransactionObject } from '../../common/pay_theory_types';
 
@@ -8,22 +10,18 @@ class PayTheoryCheckoutButton extends HTMLElement {
   protected _onClick: () => void;
   protected _onError: (error: string) => void;
   protected _onSuccess: (message: { data: SuccessfulTransactionObject }) => void;
-  protected _clearReadyListener: () => void | undefined;
-  protected _clearClickListener: () => void | undefined;
-  protected _clearErrorListener: () => void | undefined;
-  protected _clearSuccessListener: () => void | undefined;
-  protected _clearBarcodeReceivedListener: () => void | undefined;
+  protected _clearReadyListener: (() => void) | undefined;
+  protected _clearClickListener: (() => void) | undefined;
+  protected _clearErrorListener: (() => void) | undefined;
+  protected _clearSuccessListener: (() => void) | undefined;
+  protected _clearBarcodeReceivedListener: (() => void) | undefined;
   protected _closeInterval: ReturnType<typeof setInterval> | undefined;
   protected _checkoutWindow: Window | undefined;
   protected _buttonBarcode: string | undefined;
   protected _session: string | undefined;
 
   constructor() {
     super();
-    this._onReady = () => {};
-    this._onClick = () => {};
-    this._onError = () => {};
-    this._onSuccess = () => {};
   }
 
   defineButton() {
@@ -68,14 +66,12 @@ class PayTheoryCheckoutButton extends HTMLElement {
   }
 
   disconnectedCallback() {
-    this._clearErrorListener();
-    this._clearSuccessListener();
-    this._clearReadyListener();
-    this._clearClickListener();
-    this._clearBarcodeReceivedListener();
-    if (this._closeInterval) {
-      clearInterval(this._closeInterval);
-    }
+    if (this._clearErrorListener) this._clearErrorListener();
+    if (this._clearSuccessListener) this._clearSuccessListener();
+    if (this._clearReadyListener) this._clearReadyListener();
+    if (this._clearClickListener) this._clearClickListener();
+    if (this._clearBarcodeReceivedListener) this._clearBarcodeReceivedListener();
+    if (this._closeInterval) clearInterval(this._closeInterval);
   }
 
   // Only want to allow event listeners to be set from outside the class

src/components/pay-theory-checkout-qr/index.ts

@@ -1,23 +1,21 @@
 /* global HTMLElement */
+/* eslint-disable no-unused-vars */
+
 import common from '../../common';
 
 class PayTheoryCheckoutQR extends HTMLElement {
   protected _token: string | undefined;
   protected _size: number | undefined;
-  protected _onReady: (message: unknown) => void;
-  protected _onClick: (message: unknown) => void;
-  protected _onError: (message: unknown) => void;
-  protected _onSuccess: (message: unknown) => void;
-  protected _clearReadyListener: () => void | undefined;
-  protected _clearSuccessListener: () => void | undefined;
-  protected _clearErrorListener: () => void | undefined;
+  protected _onReady: ((message: unknown) => void) | undefined;
+  protected _onClick: ((message: unknown) => void) | undefined;
+  protected _onError: ((message: unknown) => void) | undefined;
+  protected _onSuccess: ((message: unknown) => void) | undefined;
+  protected _clearReadyListener: (() => void) | undefined;
+  protected _clearSuccessListener: (() => void) | undefined;
+  protected _clearErrorListener: (() => void) | undefined;
 
   constructor() {
     super();
-    this._onReady = () => {};
-    this._onClick = () => {};
-    this._onError = () => {};
-    this._onSuccess = () => {};
   }
 
   defineQR() {
@@ -51,9 +49,9 @@ class PayTheoryCheckoutQR extends HTMLElement {
   }
 
   disconnectedCallback() {
-    this._clearSuccessListener();
-    this._clearReadyListener();
-    this._clearErrorListener();
+    if (this._clearSuccessListener) this._clearSuccessListener();
+    if (this._clearReadyListener) this._clearReadyListener();
+    if (this._clearErrorListener) this._clearErrorListener();
   }
 
   // Only want to allow event listeners to be set from outside the class

src/components/pay-theory-hosted-field-transactional/index.ts

@@ -1,5 +1,4 @@
 /* eslint-disable no-unused-vars */
-
 /* eslint-disable no-empty-function */
 
 import PayTheoryHostedField from '../pay-theory-hosted-field';
@@ -121,10 +120,10 @@ class PayTheoryHostedFieldTransactional extends PayTheoryHostedField {
   protected _transactingType: TransactingType;
 
   // Function used to remove event listeners
-  protected _removeEventListeners: () => void = () => {};
-  protected _removeHostTokenListener: () => void = () => {};
-  protected _removeFeeListener: () => void = () => {};
-  protected _removeFeeCalcReconnect: () => void = () => {};
+  protected _removeEventListeners: (() => void) | undefined;
+  protected _removeHostTokenListener: (() => void) | undefined;
+  protected _removeFeeListener: (() => void) | undefined;
+  protected _removeFeeCalcReconnect: (() => void) | undefined;
 
   // Used for backwards compatibility with feeMode
   protected _feeMode: typeof common.SERVICE_FEE | typeof common.MERCHANT_FEE | undefined;
@@ -283,10 +282,10 @@ class PayTheoryHostedFieldTransactional extends PayTheoryHostedField {
   }
 
   disconnectedCallback() {
-    this._removeEventListeners();
-    this._removeHostTokenListener();
-    this._removeFeeListener();
-    this._removeFeeCalcReconnect();
+    if (this._removeEventListeners) this._removeEventListeners();
+    if (this._removeHostTokenListener) this._removeHostTokenListener();
+    if (this._removeFeeListener) this._removeFeeListener();
+    if (this._removeFeeCalcReconnect) this._removeFeeCalcReconnect();
   }
 
   async transact(data: TransactDataObject, element: PayTheoryHostedFieldTransactional) {

src/components/pay-theory-overlay/index.ts

@@ -3,15 +3,13 @@ import common from '../../common';
 
 class PayTheoryOverlay extends HTMLElement {
   protected _token: string | undefined;
-  protected _onFocus: () => void;
-  protected _onCancel: () => void;
-  protected _clearFocusListener: () => void = () => {};
-  protected _clearCancelListener: () => void = () => {};
+  protected _onFocus: (() => void) | undefined;
+  protected _onCancel: (() => void) | undefined;
+  protected _clearFocusListener: (() => void) | undefined;
+  protected _clearCancelListener: (() => void) | undefined;
 
   constructor() {
     super();
-    this._onFocus = () => {};
-    this._onCancel = () => {};
   }
 
   defineOverlay() {
@@ -28,17 +26,21 @@ class PayTheoryOverlay extends HTMLElement {
     // Adding the event listeners for the overlay
     this._clearCancelListener = common.handleHostedFieldMessage(
       common.overlayCancelTypeMessage,
-      this._onCancel,
+      () => {
+        if (this._onCancel) this._onCancel();
+      },
     );
     this._clearFocusListener = common.handleHostedFieldMessage(
       common.overlayRelaunchTypeMessage,
-      this._onFocus,
+      () => {
+        if (this._onFocus) this._onFocus();
+      },
     );
   }
 
   disconnectedCallback() {
-    this._clearCancelListener();
-    this._clearFocusListener();
+    if (this._clearCancelListener) this._clearCancelListener();
+    if (this._clearFocusListener) this._clearFocusListener();
   }
 
   // Only want to allow event listeners to be set from outside the class

src/field-set/actions.ts

@@ -34,7 +34,9 @@ const updateElementFromAction = (
 ) => {
   if (message.type === ResponseMessageTypes.ERROR || message.type === ResponseMessageTypes.FAILED) {
     iframe.initialized = false;
-    iframe.resetToken();
+    iframe.resetToken().catch(e => {
+      console.error(e);
+    });
   } else if (message.type !== ResponseMessageTypes.CONFIRMATION) {
     iframe.complete = true;
   }
@@ -43,7 +45,7 @@ const updateElementFromAction = (
 const reconnectIfDisconnected = async (
   iframe: PayTheoryHostedFieldTransactional,
 ): Promise<ErrorResponse | null> => {
-  if (iframe.connected == false) {
+  if (!iframe.connected) {
     const result = await iframe.resetToken();
     if (result.type === ResponseMessageTypes.ERROR) {
       return common.handleTypedError(ErrorType.SOCKET_ERROR, result.error);
@@ -76,9 +78,9 @@ export const transact = async (
         ErrorType.ACTION_IN_PROGRESS,
         'this function has already been called',
       );
-    } else if (transactingElement.valid == false) {
+    } else if (!transactingElement.valid) {
       return common.handleTypedError(ErrorType.NOT_VALID, 'The transaction element is invalid');
-    } else if (transactingElement.ready == false) {
+    } else if (!transactingElement.ready) {
       return common.handleTypedError(ErrorType.NOT_READY, 'The transaction element is not ready');
     } else {
       const reconnectError = await reconnectIfDisconnected(transactingElement);
@@ -87,14 +89,14 @@ export const transact = async (
       transactingElement.initialized = true;
       const newProps = common.parseInputParams(props) as ModifiedTransactProps;
       const { payorInfo, customerInfo, shippingDetails } = newProps;
-      newProps.payorInfo = payorInfo || customerInfo || shippingDetails || {};
+      newProps.payorInfo = payorInfo ?? customerInfo ?? shippingDetails ?? {};
       // Adding line for backwards compatability. Default to what was passed into the transact function, then the one passed into create, then the default
       newProps.feeMode = newProps.feeMode
         ? newProps.feeMode
         : transactingElement.feeMode
           ? transactingElement.feeMode
           : MERCHANT_FEE;
-      // @ts-ignore Adding line for backwards compatibility
+      // @ts-expect-error Adding line for backwards compatibility
       newProps.feeMode = newProps.feeMode === 'interchange' ? MERCHANT_FEE : newProps.feeMode;
       // Check for validity of the transaction parameters
       const validity = valid.validTransactionParams(newProps);
@@ -125,7 +127,8 @@ export const transact = async (
         sendObserverMessage(parsedResponse);
         return parsedResponse;
       } catch (e) {
-        return common.handleError(e?.error || e?.message || e);
+        const errorString: string = e?.error || e?.message || e;
+        return common.handleError(errorString);
       }
     }
   } else {
@@ -163,7 +166,6 @@ export const confirm = async (): Promise<
   }
 };
 
-// @ts-ignore
 export const cancel = async (): Promise<true | ErrorResponse> => {
   const transactingElement = findTransactingElement();
   if (transactingElement) {
@@ -237,7 +239,7 @@ export const tokenizePaymentMethod = async (
   }
 };
 
-export const activateCardPresentDevice = async (): Promise<ErrorResponse | true> => {
+export const activateCardPresentDevice = (): ErrorResponse | true => {
   return true;
 };
 
@@ -253,7 +255,7 @@ export const updateAmount = async (amount: number): Promise<ErrorResponse | true
     const elements = document.getElementsByName(id);
     if (elements.length) {
       const transactingElement = elements[0] as PayTheoryHostedFieldTransactional;
-      if (transactingElement.ready == false) {
+      if (!transactingElement.ready) {
         return common.handleTypedError(
           ErrorType.NOT_READY,
           'Not all fields are ready to update the amount',

src/field-set/payment-button.ts

@@ -1,23 +1,23 @@
 /* eslint no-console: ["error", { allow: ["warn", "error"] }] */
 // eslint-disable-next-line @typescript-eslint/no-unused-vars
-/*global navigator*/
 import common from '../common';
 import * as valid from './validation';
 import {
   PayTheoryButtonInput,
   SuccessfulTransactionObject,
   ErrorResponse,
+  CashBarcodeObject,
 } from '../common/pay_theory_types';
 import { ModifiedCheckoutDetails } from '../common/format';
 import PayTheoryCheckoutButton from '../components/pay-theory-checkout-button';
 import PayTheoryOverlay from '../components/pay-theory-overlay';
 
 const PopupCenter = (url: string, title: string, w: number, h: number) => {
   // Fixes dual-screen position                         Most browsers      Firefox
-  // @ts-ignore ignore screen error for firefox
-  const dualScreenLeft = window.screenLeft != undefined ? window.screenLeft : screen.left;
-  // @ts-ignore ignore screen error for firefox
-  const dualScreenTop = window.screenTop != undefined ? window.screenTop : screen.top;
+  // @ts-expect-error ignore screen error for firefox
+  const dualScreenLeft: number = window.screenLeft ?? screen.left;
+  // @ts-expect-error ignore screen error for firefox
+  const dualScreenTop: number = window.screenTop ?? screen.top;
 
   const width = window.innerWidth
     ? window.innerWidth
@@ -112,7 +112,7 @@ export default async (inputParams: PayTheoryButtonInput) => {
     // Remove the error listener because we added it to the button iFrame and do not want it to be called twice
     removeErrorListener();
     removeHostedErrorListener();
-    if (data && data?.sessionId) {
+    if (data && data.sessionId) {
       const buttonElement = getCheckoutButton();
       buttonElement.session = data.sessionId;
     }
@@ -126,7 +126,7 @@ export default async (inputParams: PayTheoryButtonInput) => {
     // Check to see if a barcode response was sent back to tell which callback to call
     const buttonElement = getCheckoutButton();
     if (buttonElement?.buttonBarcode) {
-      if (onBarcode) onBarcode(JSON.parse(buttonElement.buttonBarcode));
+      if (onBarcode) onBarcode(JSON.parse(buttonElement.buttonBarcode) as CashBarcodeObject);
     } else {
       if (onCancel) onCancel();
     }

src/field-set/payment-qr.ts

@@ -1,10 +1,10 @@
 /* eslint no-console: ["error", { allow: ["warn", "error"] }] */
 // eslint-disable-next-line @typescript-eslint/no-unused-vars
-/*global navigator*/
+
 import common from '../common';
 import * as valid from './validation';
 import PayTheoryCheckoutQR from '../components/pay-theory-checkout-qr';
-import { PayTheoryQRInput } from '../common/pay_theory_types';
+import { PayTheoryQRInput, SuccessfulTransactionObject } from '../common/pay_theory_types';
 import { ErrorMessage, ModifiedCheckoutDetails } from '../common/format';
 
 export default async (inputParams: PayTheoryQRInput) => {
@@ -59,7 +59,11 @@ export default async (inputParams: PayTheoryQRInput) => {
   tagFrame.setAttribute('id', `${common.checkoutQRField}-wrapper`);
   tagFrame.size = finalSize;
   tagFrame.onReady = onReadyWrapper;
-  if (onSuccess) tagFrame.onSuccess = (message: MessageEvent) => onSuccess(message.data);
+  if (onSuccess) {
+    tagFrame.onSuccess = (message: MessageEvent) => {
+      onSuccess(message.data as SuccessfulTransactionObject);
+    };
+  }
   if (onError) tagFrame.onError = onError;
   // Append the button div to the wrapper div
   const qrDiv = document.getElementById(common.checkoutQRField);