payjoin-cli RPC errors are obscured

[spacebear21]

For example:

❯ cargo run -- receive 1000
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.10s
     Running `/Users/spacebear/Projects/rust-payjoin/target/debug/payjoin-cli receive 1000`
Error: Failed to get new address

Caused by:
    Obtained failure status(500): Internal Server Error

This error message doesn't tell me what to do. The underlying issue was that I needed to load the bitcoin-cli wallet:

❯ bitcoin-cli -rpcwallet=receiver getnewaddress
error code: -18
error message:
Requested wallet does not exist or is not loaded

❯ bitcoin-cli loadwallet receiver
{
  "name": "receiver"
}

Error responses from the bitcoin-cli RPC should be propagated and displayed to the payjoin-cli user. This may be a limitation inherent from the bitcoind-async-client library in which case it should be addressed upstream.

[abhinavraajput]

Hi! I’d like to work on this issue if it’s still available.

I’ve reproduced the problem and the root cause seems to be that the
Bitcoin Core JSON-RPC error (e.g. -18: wallet not loaded) is being
collapsed into a generic HTTP 500. I plan to fix this by propagating
the RPC error code and message to the payjoin-cli output (or upstream
in bitcoind-async-client if appropriate).

Please let me know if I can be assigned. Thanks!

[spacebear21]

Sure thing! I've assigned you to the issue.