Skip to content

Commit 191a8ad

Browse files
committed
fix: Render fallback on image if mimeType doesn't match with video type
1 parent e8115e5 commit 191a8ad

File tree

2 files changed

+14
-12
lines changed

2 files changed

+14
-12
lines changed

Diff for: packages/ui/src/elements/Thumbnail/index.tsx

+13-11
Original file line numberDiff line numberDiff line change
@@ -54,17 +54,19 @@ export const Thumbnail = (props: ThumbnailProps) => {
5454
return (
5555
<div className={classNames}>
5656
{fileExists === undefined && <ShimmerEffect height="100%" />}
57-
{fileExists && fileType === 'image' && <img alt={alt} src={src} />}
58-
{fileExists && fileType === 'video' && (
59-
<video
60-
aria-label={alt}
61-
autoPlay={false}
62-
controls={false}
63-
muted={true}
64-
playsInline={true}
65-
src={src}
66-
/>
67-
)}
57+
{fileExists &&
58+
(fileType === 'video' ? (
59+
<video
60+
aria-label={alt}
61+
autoPlay={false}
62+
controls={false}
63+
muted={true}
64+
playsInline={true}
65+
src={src}
66+
/>
67+
) : (
68+
<img alt={alt} src={src} />
69+
))}
6870
{fileExists === false && <File />}
6971
</div>
7072
)

Diff for: test/uploads/e2e.spec.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -262,7 +262,7 @@ describe('uploads', () => {
262262
await page.goto(customFileNameURL.create)
263263
await page.setInputFiles('input[type="file"]', path.resolve(dirname, './image.png'))
264264

265-
// await expect(page.locator('.file-field__upload .thumbnail img')).toBeVisible()
265+
await expect(page.locator('.file-field__upload .thumbnail img')).toBeVisible()
266266

267267
await saveDocAndAssert(page)
268268

0 commit comments

Comments
 (0)