fix(db-mongodb): documentDB unique constraint throws incorrect error

Author: DanRibbens

Diff for: packages/db-mongodb/src/create.ts

@@ -3,9 +3,8 @@ import type { Document, PayloadRequest } from 'payload/types'
 
 import type { MongooseAdapter } from '.'
 
+import handleError from './utilities/handleError'
 import { withSession } from './withSession'
-import { ValidationError } from 'payload/errors'
-import { i18nInit } from 'payload/utilities'
 
 export const create: Create = async function create(
   this: MongooseAdapter,
@@ -17,18 +16,7 @@ export const create: Create = async function create(
   try {
     ;[doc] = await Model.create([data], options)
   } catch (error) {
-    // Handle uniqueness error from MongoDB
-    throw error.code === 11000 && error.keyValue
-      ? new ValidationError(
-          [
-            {
-              field: Object.keys(error.keyValue)[0],
-              message: req.t('error:valueMustBeUnique'),
-            },
-          ],
-          req?.t ?? i18nInit(this.payload.config.i18n).t,
-        )
-      : error
+    handleError(error, req)
   }
 
   // doc.toJSON does not do stuff like converting ObjectIds to string, or date strings to date objects. That's why we use JSON.parse/stringify here

Diff for: packages/db-mongodb/src/updateOne.ts

@@ -1,11 +1,9 @@
 import type { UpdateOne } from 'payload/database'
 import type { PayloadRequest } from 'payload/types'
 
-import { ValidationError } from 'payload/errors'
-import { i18nInit } from 'payload/utilities'
-
 import type { MongooseAdapter } from '.'
 
+import handleError from './utilities/handleError'
 import sanitizeInternalFields from './utilities/sanitizeInternalFields'
 import { withSession } from './withSession'
 
@@ -31,18 +29,7 @@ export const updateOne: UpdateOne = async function updateOne(
   try {
     result = await Model.findOneAndUpdate(query, data, options)
   } catch (error) {
-    // Handle uniqueness error from MongoDB
-    throw error.code === 11000 && error.keyValue
-      ? new ValidationError(
-          [
-            {
-              field: Object.keys(error.keyValue)[0],
-              message: 'Value must be unique',
-            },
-          ],
-          req?.t ?? i18nInit(this.payload.config.i18n).t,
-        )
-      : error
+    handleError(error, req)
   }
 
   result = JSON.parse(JSON.stringify(result))

Diff for: packages/db-mongodb/src/utilities/handleError.ts

@@ -0,0 +1,23 @@
+import httpStatus from 'http-status'
+import { APIError, ValidationError } from 'payload/errors'
+
+const handleError = (error, req) => {
+  // Handle uniqueness error from MongoDB
+  if (error.code === 11000 && error.keyValue) {
+    throw new ValidationError(
+      [
+        {
+          field: Object.keys(error.keyValue)[0],
+          message: req.t('error:valueMustBeUnique'),
+        },
+      ],
+      req.t,
+    )
+  } else if (error.code === 11000) {
+    throw new APIError(req.t('error:valueMustBeUnique'), httpStatus.BAD_REQUEST)
+  } else {
+    throw error
+  }
+}
+
+export default handleError