Skip to content

Commit fcf639f

Browse files
refactor: rename hiddenInVersionView to disableVersionDiff
For consistency with disabled, disableListColumn and disableListFiter
1 parent 4544268 commit fcf639f

File tree

5 files changed

+13
-15
lines changed

5 files changed

+13
-15
lines changed

Diff for: docs/fields/overview.mdx

+1-1
Original file line numberDiff line numberDiff line change
@@ -440,8 +440,8 @@ The following options are available:
440440
| **`disableBulkEdit`** | Set `disableBulkEdit` to `true` to prevent fields from appearing in the select options when making edits for multiple documents. Defaults to `true` for UI fields. |
441441
| **`disableListColumn`** | Set `disableListColumn` to `true` to prevent fields from appearing in the list view column selector. |
442442
| **`disableListFilter`** | Set `disableListFilter` to `true` to prevent fields from appearing in the list view filter options. |
443+
| **`disableVersionDiff`** | Set `disableVersionDiff` to `true` to prevent fields from appearing in the version view. |
443444
| **`hidden`** | Will transform the field into a `hidden` input type. Its value will still submit with requests in the Admin Panel, but the field itself will not be visible to editors. |
444-
| **`hiddenInVersionView`** | Set `hiddenInVersionView` to `true` to prevent fields from appearing in the version view. |
445445

446446
### Field Descriptions
447447

Diff for: packages/next/src/views/Version/RenderFieldsToDiff/utilities/isFieldHiddenInVersionView.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -25,9 +25,9 @@ export function isFieldHiddenInVersionView(field: ClientField | Field) {
2525
return true
2626
}
2727

28-
// Don't render fields with admin.hiddenInVersionView, because they are
28+
// Don't render fields with admin.disableVersionDiff, because they are
2929
// supposed to be hidden specifically in the version view.
30-
if (field.admin?.hiddenInVersionView) {
30+
if (field.admin?.disableVersionDiff) {
3131
return true
3232
}
3333

Diff for: packages/payload/src/fields/config/types.ts

+4-4
Original file line numberDiff line numberDiff line change
@@ -347,12 +347,12 @@ type Admin = {
347347
* @type boolean
348348
*/
349349
disableListFilter?: boolean
350-
hidden?: boolean
351350
/**
352351
* Shows / hides fields in the version diff view.
353352
* @type boolean
354353
*/
355-
hiddenInVersionView?: boolean
354+
disableVersionDiff?: boolean
355+
hidden?: boolean
356356
position?: 'sidebar'
357357
readOnly?: boolean
358358
style?: CSSProperties
@@ -376,12 +376,12 @@ export type AdminClient = {
376376
* @type boolean
377377
*/
378378
disableListFilter?: boolean
379-
hidden?: boolean
380379
/**
381380
* Shows / hides fields in the version diff view.
382381
* @type boolean
383382
*/
384-
hiddenInVersionView?: boolean
383+
disableVersionDiff?: boolean
384+
hidden?: boolean
385385
position?: 'sidebar'
386386
readOnly?: boolean
387387
style?: { '--field-width'?: CSSProperties['width'] } & CSSProperties

Diff for: test/versions/collections/Diff.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -196,10 +196,10 @@ export const Diff: CollectionConfig = {
196196
},
197197
},
198198
{
199-
name: 'adminHiddenInVersionView',
199+
name: 'adminDisableVersionDiff',
200200
type: 'text',
201201
admin: {
202-
hiddenInVersionView: true,
202+
disableVersionDiff: true,
203203
},
204204
},
205205
],

Diff for: test/versions/e2e.spec.ts

+4-6
Original file line numberDiff line numberDiff line change
@@ -1575,14 +1575,12 @@ describe('Versions', () => {
15751575
await expect(adminDisabledField).toBeHidden()
15761576
})
15771577

1578-
test('should not render fields with admin.hiddenInVersionView: true', async () => {
1578+
test('should not render fields with admin.disableVersionView: true', async () => {
15791579
await navigateToVersionFieldsDiff()
15801580

1581-
// Fields with admin.hiddenInVersionView should be hidden in the version view
1582-
const adminHiddenInVersionViewView = page.locator(
1583-
'[data-field-path="adminHiddenInVersionView"]',
1584-
)
1585-
await expect(adminHiddenInVersionViewView).toBeHidden()
1581+
// Fields with admin.disableVersionDiff should be hidden in the version view
1582+
const adminDisableVersionDiff = page.locator('[data-field-path="adminDisableVersionDiff"]')
1583+
await expect(adminDisableVersionDiff).toBeHidden()
15861584
})
15871585
})
15881586
})

0 commit comments

Comments
 (0)