Just wondering, when was the last successful build step? #7423
Replies: 2 comments 2 replies
-
Hey @mxchinegod are you referring to the Payload core codebase? In that case we have a LOT of tests and a few specific tests are flaky, so the build can show as errored even if there is a flake in a test. We are working toward ensuring that the flakes are ironed out but it can be difficult especially on the E2E side. We tend to prioritize fixes over flakes and then circle back to ensuring tests are as flake-less as possible.
Issues do not necessarily correlate to build steps, so I am not following there, but we try our hardest to keep up with issues that are reliably reproducible and can be demonstrated to be a bug. In practice, many issues are created which do not have a reproduction, are not reproducible even if we wrote our own, or are not related to Payload code. In those cases we do convert to Discussions in order to keep Payload's GitHub issues related to concrete bugs / issues with Payload core code.
2.0 is, but 3.0 is definitely still in beta. There are lots of people that use it in production and we are close to having full stable, but that's kind of a "choose your own adventure" type deal at this point. If you're looking for as much stability as possible I'd stay on 2.0 until we hit 3.0 stable. It sounds like you are mostly running into Docker / Sharp issues, which is fair, because Sharp is very, very picky. Generally there is an answer (Sharp is incompatible with certain Docker images, etc) and there are many issues but generally what that means for Payload is that we have to go diagnose someone's exact Docker / Sharp / Node / package manager versions and the answer can change depending on the exact combination of those factors. It's exhausting, frankly, and there might not be a single Dockerfile that works for everyone's exact use case. The Dockerfiles that we ship with might work for one machine, but might not for another. This is more appropriate as a GitHub discussion though, and not an issue, for some of the reasons that I stated above (it's not a reproducible issue with Payload). Happy to keep the conversation going though and if you'd like to point us to an exact error that you're having, which we can reproduce, we would be happy to tackle it! |
Beta Was this translation helpful? Give feedback.
-
Hi, I just want to say that I'm using 3.0 with Docker for like 5+ websites successfully. The only real issue is with Next.js I had the My FROM node:20-alpine AS base
ENV PNPM_HOME="/pnpm"
ENV PATH="$PNPM_HOME:$PATH"
RUN corepack enable
FROM base AS build
COPY . /usr/src/app
WORKDIR /usr/src/app
RUN --mount=type=cache,id=pnpm,target=/pnpm/store pnpm install --frozen-lockfile
RUN pnpm build:cms
RUN pnpm deploy --filter=@monorepo/cms /prod/cms
FROM base AS cms
COPY --from=build /prod/cms /prod/cms
WORKDIR /prod/cms
EXPOSE 3000
CMD [ "pnpm", "prod"] If you even have issues with 2.0, I bet you're trying to build that on ARM64 - try a normal x86 PC. |
Beta Was this translation helpful? Give feedback.
-
All of them are failing or turned off so I'm just wondering what to install/pull? There are many, many "closed" issues with the Dockerfile, 'sharp', build step yet none of the suggestions from the team have solved the issues.
Many issues are closed before build step is considered.
Is this stable enough to use in production or no?
Again, getting the basic 2.x, 3.0 create-app Dockerfiles to work is incomplete, so it would be good to focus not on getting a dev environment running (since that only takes you so far!) but can anyone confirm this builds without issues with 'sharp', OOTB, without modifications?
I can link to all of the issues I have mentioned but I have a suspicion a lot of it is fresh in memory for the team :) there are a LOT of complaints about 'sharp', dockerfile from vanilla app not working, but they are closed early.
Beta Was this translation helpful? Give feedback.
All reactions