fix: resets pagination when search term changes in drawer list #5599
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PatrikKozak
requested review from
jmikrut,
jacobsfletch and
JarrodMFlesch
as code owners
|
@jacobsfletch I think you'd be best to help review this with me. When you have some time could we look at this PR together? Thanks! |
jacobsfletch
reviewed
Apr 4, 2024
| @@ -198,6 +198,10 @@ export const ListDrawerContent: React.FC<ListDrawerProps> = ({ | |||
| setPreference(preferenceKey, newPreferences, true) | |||
| }, [sort, limit, setPreference, preferenceKey]) | |||
|
|
|||
| useEffect(() => { | |||
There was a problem hiding this comment.
Hmmm, this isn't quite right. Instead of adding a new useEffect, you should be able to tie into the methods that the SearchFilter component exposed via props. The drawer sets modifySearchParams to false, which is where the page reset is being bypassed. Basically just need to thread the page reset back into the search before it's set, instead of after its set.
There was a problem hiding this comment.
Notes:
- Consolidate all 5
useStates in theListDrawercomponent - Replace them with a new
paramsstate, and completely remove theuseEffect - This would mean that the filter options injected into the
wherequery, and the conditions formatted from thesearchstring, need to become methods that properly setparams - This is exactly what a reducer is for, might as well use it. We can create reducer actions like
setSearch which properly formatsconditionsand resetspage, andsetWhere,setParamsto blindy set any of them, etc. - This all makes it so that the
usePayloadAPIhook (which makes an API request) is only fired once no matter what params change and when
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix: resets pagination to page 1 every time the search term changes
Type of change
Checklist: