ncps - expand inline guest (#2356)

Author: jshawl

Diff for: src/hosted-buttons/utils.js

@@ -7,6 +7,7 @@ import {
   getClientID,
   getMerchantID as getSDKMerchantID,
 } from "@paypal/sdk-client/src";
+import { FUNDING } from "@paypal/sdk-constants/src";
 
 import type {
   ButtonVariables,
@@ -208,6 +209,14 @@ export const buildHostedButtonOnApprove = ({
         merchant_id: merchantId,
         context_id: data.orderID,
       }),
+    }).then((response) => {
+      // The "Debit or Credit Card" button does not open a popup
+      // so we need to redirect to the thank you page for buyers who complete
+      // a checkout via "Debit or Credit Card".
+      if (data.paymentSource === FUNDING.CARD) {
+        window.location = `${baseUrl}/ncp/payment/${hostedButtonId}/${data.orderID}`;
+      }
+      return response;
     });
   };
 };

Diff for: src/hosted-buttons/utils.test.js

@@ -264,6 +264,28 @@ describe("buildHostedButtonOnApprove", () => {
     );
     expect.assertions(1);
   });
+
+  describe("inline guest", () => {
+    const onApprove = buildHostedButtonOnApprove({
+      hostedButtonId,
+      merchantId,
+    });
+    // $FlowIssue
+    request.mockImplementation(() =>
+      // eslint-disable-next-line compat/compat
+      Promise.resolve({
+        body: {},
+      })
+    );
+
+    test("redirects from the merchant's site to a thank you page", async () => {
+      expect(window.location.href).toBe("http://localhost:3000/");
+      await onApprove({ orderID, paymentSource: "card" });
+      expect(window.location).toBe(
+        "https://example.com/ncp/payment/B1234567890/EC-1234567890"
+      );
+    });
+  });
 });
 
 /* eslint-enable no-restricted-globals, promise/no-native */