Skip to content

Commit 9cc6304

Browse files
committed
chore(refactor): naming
1 parent 0ba995a commit 9cc6304

File tree

4 files changed

+6
-6
lines changed

4 files changed

+6
-6
lines changed

src/funding/venmo/config.jsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ export function getVenmoConfig(): FundingSourceConfig {
6363
platform === PLATFORM.MOBILE &&
6464
experiment &&
6565
experiment.venmoWebEnabled === false &&
66-
experiment.venmoEnableOnNonNativeBrowser === false
66+
experiment.venmoEnableWebOnNonNativeBrowser === false
6767
) {
6868
return {
6969
native: true,

src/funding/venmo/config.test.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ describe("Venmo eligibility", () => {
1313
fundingEligibility: {},
1414
experiment: {
1515
venmoWebEnabled: true,
16-
venmoEnableOnNonNativeBrowser: true,
16+
venmoEnableWebOnNonNativeBrowser: true,
1717
},
1818
wallet: expect.any,
1919
flow: BUTTON_FLOW.PURCHASE,
@@ -75,7 +75,7 @@ describe("Venmo eligibility", () => {
7575
expect(isVenmoEligible).toEqual(true);
7676
});
7777

78-
test("should not be eligible if a shipping callback is passed & experiment does not include venmoWebEnabled or venmoEnableOnNonNativeBrowser", () => {
78+
test("should not be eligible if a shipping callback is passed & experiment does not include venmoWebEnabled or venmoEnableWebOnNonNativeBrowser", () => {
7979
const isVenmoEligible = venmoConfig.eligible?.({
8080
...baseEligibilityProps,
8181
experiment: {},
@@ -85,7 +85,7 @@ describe("Venmo eligibility", () => {
8585
expect(isVenmoEligible).toEqual(false);
8686
});
8787

88-
test("should be eligible if shipping callback exists & experiment includes venmoWebEnabled or venmoEnableOnNonNativeBrowser", () => {
88+
test("should be eligible if shipping callback exists & experiment includes venmoWebEnabled or venmoEnableWebOnNonNativeBrowser", () => {
8989
const isVenmoEligible = venmoConfig.eligible?.({
9090
...baseEligibilityProps,
9191
shippingChange: true,

src/types.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ export type Experiment = {|
6262
venmoWebEnabled?: boolean,
6363
// first render experiments
6464
venmoVaultWithoutPurchase?: boolean,
65-
venmoEnableOnNonNativeBrowser?: boolean,
65+
venmoEnableWebOnNonNativeBrowser?: boolean,
6666
|};
6767

6868
export type Requires = {|

src/zoid/venmo/component.jsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -296,7 +296,7 @@ export function getVenmoCheckoutComponent(): VenmoCheckoutComponent {
296296
required: false,
297297
},
298298

299-
venmoEnableOnNonNativeBrowser: {
299+
venmoEnableWebOnNonNativeBrowser: {
300300
type: "boolean",
301301
queryParam: true,
302302
required: false,

0 commit comments

Comments
 (0)