Merge pull request #7 from paytrail/make-items-optional

Make items optional

Author: kotivuori

paytrail-ios-sdk.podspec

@@ -1,7 +1,7 @@
 Pod::Spec.new do |spec|
 
   spec.name         = "paytrail-ios-sdk"
-  spec.version      = "1.0.0-beta5"
+  spec.version      = "1.0.0-beta6"
   spec.summary      = "Paytrail Mobile SDK for iOS"
   spec.description  = <<-DESC
   Paytrail iOS SDK providing the major payment features for easy mobile payments.

paytrail-ios-sdk/Networking/Models/CreatePayment/PaymentRequestBody.swift

@@ -29,7 +29,7 @@ public struct PaymentRequestBody : Codable {
     public let language : Language
 
     /// Array of items. Always required for Shop-in-Shop payments. Required if VAT calculations are wanted in settlement reports.
-    public let items : [Item]
+    public let items : [Item]?
 
     /// Customer information, see Customer
     public let customer : Customer
@@ -69,7 +69,7 @@ public struct PaymentRequestBody : Codable {
          amount: Int,
          currency: Currency,
          language: Language,
-         items: [Item],
+         items: [Item]? = nil,
          customer: Customer,
          redirectUrls: CallbackUrls,
          callbackUrls: CallbackUrls? = nil,

paytrail-ios-sdkTests/CreatePaymentApiTestSuite.swift

@@ -14,6 +14,7 @@ final class CreatePaymentApiTestSuite: XCTestCase {
 //    var merchantSIS: PaytrailMerchant! // Shop-in-shops merchant
     var payload: PaymentRequestBody!
     var payloadInvalid: PaymentRequestBody!
+    var payloadNoItems: PaymentRequestBody!
     var payloadSIS: PaymentRequestBody!
     var providerImageUrl: String!
     var providerImageUrlInvalid: String!
@@ -37,6 +38,15 @@ final class CreatePaymentApiTestSuite: XCTestCase {
                                      redirectUrls: CallbackUrls(success: "google.com", cancel: "google.com"),
                                      callbackUrls: nil)
 
+        payloadNoItems = PaymentRequestBody(stamp: UUID().uuidString,
+                                     reference: "3759170",
+                                     amount: 3050,
+                                     currency: .eur,
+                                     language: .fi,
+                                     customer: Customer(email: "test.customer@example.com"),
+                                     redirectUrls: CallbackUrls(success: "google.com", cancel: "google.com"),
+                                     callbackUrls: nil)
+        
         payloadSIS = PaymentRequestBody(stamp: UUID().uuidString,
                                         reference: "3759170",
                                         amount: 3050,
@@ -87,6 +97,17 @@ final class CreatePaymentApiTestSuite: XCTestCase {
         }
     }
 
+    /// Test Success 200 - Payment create success with normal merchant credentials without items
+    func testCreateNoItemsPaymentSuccess() async {
+        let result = await createPaymentsAsync(merchant.merchantId, secret: merchant.secret, payload: payloadNoItems)
+        switch result {
+        case .success(let success):
+            XCTAssert(success.transactionId != nil && success.providers != nil)
+        case .failure(let failure):
+            XCTFail("Create payment failed: \(failure.localizedDescription)")
+        }
+    }
+    
     /// Test Success 200 - Payment create with Shop-in-Shops merchant credentials
     func testCreatePaymentSisSuccess() async {
         let result = await createPaymentsAsync("695861", secret: "MONISAIPPUAKAUPPIAS", payload: payloadSIS)