Fixing Lint and Formatting Issues

Author: Ottia

src/models/request/add-card-form.model.ts

@@ -1,4 +1,4 @@
-import { IsNotEmpty, IsNumber, IsOptional, IsString } from 'class-validator'
+import { IsNotEmpty, IsOptional, IsString } from 'class-validator'
 
 /**
  * Class AddCardFormRequest

src/models/request/request-model/item.model.ts

@@ -1,8 +1,6 @@
 import { IsNotEmpty, IsNumber, IsOptional, IsString, Length, Max, Min } from 'class-validator'
 import 'reflect-metadata'
 
- 
-
 /**
  * Class Item
  *
@@ -104,5 +102,4 @@ export class Item {
   @IsOptional()
   @Length(0, 50)
   public merchant?: string
-
 }

src/paytrail-client.ts

@@ -1,4 +1,4 @@
-import { responseMessage, responseStatus } from './constants/message-response.constant'
+import { responseStatus } from './constants/message-response.constant'
 import { API_ENDPOINT, METHOD } from './constants/variable.constant'
 import { IPaytrail } from './interfaces/IPayTrail.interface'
 import {
@@ -350,32 +350,26 @@ export class PaytrailClient extends Paytrail implements IPaytrail {
       } as any
     }
 
-    try {
-      const payload = {
-        checkoutRedirectSuccessUrl: addCardFormRequest.checkoutRedirectSuccessUrl,
-        checkoutRedirectCancelUrl: addCardFormRequest.checkoutRedirectCancelUrl,
-        language: addCardFormRequest.language
-      }
-      const headers = this.getHeaders(METHOD.POST, null, null, payload)
-
-      // Signature override for add-card-form: Sign Method + Path + Body
-      // Headers are NOT included in this signature calculation
-
-      const signature = Signature.calculateCustomHmac(
-        this.secretKey as string,
-        'POST',
-        '/tokenization/addcard-form',
-        convertObjectKeys(payload)
-      )
-      headers['signature'] = signature
+    const payload = {
+      checkoutRedirectSuccessUrl: addCardFormRequest.checkoutRedirectSuccessUrl,
+      checkoutRedirectCancelUrl: addCardFormRequest.checkoutRedirectCancelUrl,
+      language: addCardFormRequest.language
+    }
+    const headers = this.getHeaders(METHOD.POST, null, null, payload)
 
-      const data = await api.tokenPayments.createAddCardFormRequest(payload, headers)
+    // Signature override for add-card-form: Sign Method + Path + Body
+    // Headers are NOT included in this signature calculation
 
-      return data as any
+    const signature = Signature.calculateCustomHmac(
+      this.secretKey as string,
+      'POST',
+      '/tokenization/addcard-form',
+      convertObjectKeys(payload)
+    )
+    headers['signature'] = signature
 
-      return data as any
-    } catch (error) {
-      throw error
-    }
+    const data = await api.tokenPayments.createAddCardFormRequest(payload, headers)
+
+    return data as any
   }
 }

src/utils/axios.util.ts

@@ -1,7 +1,6 @@
 import axios, { AxiosResponse } from 'axios'
 import { API_ENDPOINT } from '../constants/variable.constant'
 import {
-  AddCardFormRequest,
   AddCardFormResponse,
   CreateCitPaymentParams,
   CreateCitPaymentRequest,

src/utils/handle-request.util.ts

@@ -2,5 +2,4 @@ export const handleRequest = async <T>(promise: Promise<T>): Promise<readonly [a
   return promise
     .then((data): readonly [any, T] => [undefined, data] as const)
     .catch((err): readonly [any, T] => [err, undefined] as const)
-
 }

src/validators/unit-price.validator.ts

@@ -1,4 +1,10 @@
-import { ValidationArguments, ValidatorConstraint, ValidatorConstraintInterface, registerDecorator, ValidationOptions } from 'class-validator'
+import {
+  ValidationArguments,
+  ValidatorConstraint,
+  ValidatorConstraintInterface,
+  registerDecorator,
+  ValidationOptions
+} from 'class-validator'
 
 /**
  * Validator constraint for validating unitPrice based on context
@@ -48,9 +54,9 @@ export class IsValidUnitPriceConstraint implements ValidatorConstraintInterface
   defaultMessage(args: ValidationArguments): string {
     const object = args.object as any
     const unitPrice = args.value as number
-    
+
     const isShopInShopItem = object.merchant && object.stamp && object.reference
-    
+
     if (isShopInShopItem && unitPrice < 0) {
       return 'Shop-in-Shop items cannot have negative unitPrice'
     }
@@ -78,4 +84,4 @@ export function IsValidUnitPrice(validationOptions?: ValidationOptions) {
       validator: IsValidUnitPriceConstraint
     })
   }
-}
+}

tests/create-cit-payment-authorization-hold.test.ts

@@ -16,7 +16,7 @@ describe('create-cit-payment-authorization-hold', () => {
   standardData.amount = 1590
   standardData.currency = 'EUR'
   standardData.language = 'FI'
-  
+
   const item = new Item()
   item.unitPrice = 1590
   item.units = 1
@@ -44,7 +44,7 @@ describe('create-cit-payment-authorization-hold', () => {
   nonStandardData.amount = -1590
   nonStandardData.currency = 'EUR'
   nonStandardData.language = 'FI'
-  
+
   const nonStandardItem = new Item()
   nonStandardItem.unitPrice = 1590
   nonStandardItem.units = 1

tests/create-cit-payment-charge.test.ts

@@ -16,7 +16,7 @@ describe('create-cit-payment-charge', () => {
   standardData.amount = 1590
   standardData.currency = 'EUR'
   standardData.language = 'FI'
-  
+
   const item = new Item()
   item.unitPrice = 1590
   item.units = 1
@@ -44,7 +44,7 @@ describe('create-cit-payment-charge', () => {
   nonStandardData.amount = -1590
   nonStandardData.currency = 'EUR'
   nonStandardData.language = 'FI'
-  
+
   const nonStandardItem = new Item()
   nonStandardItem.unitPrice = 1590
   nonStandardItem.units = 1

tests/create-cit-payment-commit.test.ts

@@ -17,7 +17,7 @@ describe('create-cit-payment-commit', () => {
   standardData.amount = 1590
   standardData.currency = 'EUR'
   standardData.language = 'FI'
-  
+
   const item = new Item()
   item.unitPrice = 1590
   item.units = 1
@@ -46,7 +46,7 @@ describe('create-cit-payment-commit', () => {
   nonStandardData.amount = -1590
   nonStandardData.currency = 'EUR'
   nonStandardData.language = 'FI'
-  
+
   const nonStandardItem = new Item()
   nonStandardItem.unitPrice = 1590
   nonStandardItem.units = 1

tests/create-mit-payment-authorization-hold.test.ts

@@ -16,7 +16,7 @@ describe('create-mit-payment-authorization-hold', () => {
   standardData.amount = 1590
   standardData.currency = 'EUR'
   standardData.language = 'FI'
-  
+
   const item = new Item()
   item.unitPrice = 1590
   item.units = 1
@@ -44,7 +44,7 @@ describe('create-mit-payment-authorization-hold', () => {
   nonStandardData.amount = -1590
   nonStandardData.currency = 'EUR'
   nonStandardData.language = 'FI'
-  
+
   const nonStandardItem = new Item()
   nonStandardItem.unitPrice = 1590
   nonStandardItem.units = 1