Skip to content

When pipeline fails no PR comment added #8

@andrewgkew

Description

@andrewgkew

I was under the impression that when the action runs for a pipeline a comment will be added to the PR whether it passes or fails and if it fails you get which rules it failed on

I am getting the comment when it passes but not fails

This is what the output of the pipeline looks like

Image

My current workflow config

  vacuum-lint:
    needs: detect-changes
    if: ${{ needs.detect-changes.outputs.changes == 'true' }}
    runs-on: ubuntu-latest
    strategy:
      matrix:
        file: ${{ fromJSON(needs.detect-changes.outputs.files) }}
    steps:
      - uses: actions/checkout@v4
      - name: Run OpenAPI lint with vacuum
        uses: pb33f/vacuum-action@v2
        with:
          openapi_path: ${{ matrix.file }}
          ruleset: .github/ruleset.yaml
          show_rules: true
          fail_on_error: true
          minimum_score: 100
          print_logs: true
          github_token: ${{ secrets.GITHUB_TOKEN }}

I have also tried fail_on_error=false without success

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions