fix: Address clippy unnecessary_unwrap lint in plant login methods

Use `if let Some(err)` pattern instead of `is_none()` check followed
by `unwrap()` to satisfy clippy's unnecessary_unwrap lint.

Author: pbeets

src/plants/history_plant.rs

@@ -755,7 +755,10 @@ impl RithmicHistoryPlantHandle {
             .map_err(|_| "Connection closed".to_string())??
             .remove(0);
 
-        if response.error.is_none() {
+        if let Some(err) = response.error {
+            error!("history_plant: login failed {:?}", err);
+            Err(err)
+        } else {
             let _ = self.sender.send(HistoryPlantCommand::SetLogin).await;
 
             if let RithmicMessage::ResponseLogin(resp) = &response.message {
@@ -772,10 +775,6 @@ impl RithmicHistoryPlantHandle {
             info!("history_plant: logged in");
 
             Ok(response)
-        } else {
-            error!("history_plant: login failed {:?}", response.error);
-
-            Err(response.error.unwrap())
         }
     }
 

src/plants/order_plant.rs

@@ -1334,7 +1334,10 @@ impl RithmicOrderPlantHandle {
             .map_err(|_| "Connection closed".to_string())??
             .remove(0);
 
-        if response.error.is_none() {
+        if let Some(err) = response.error {
+            error!("order_plant: login failed {:?}", err);
+            Err(err)
+        } else {
             let _ = self.sender.send(OrderPlantCommand::SetLogin).await;
 
             if let RithmicMessage::ResponseLogin(resp) = &response.message {
@@ -1351,10 +1354,6 @@ impl RithmicOrderPlantHandle {
             info!("order_plant: logged in");
 
             Ok(response)
-        } else {
-            error!("order_plant: login failed {:?}", response.error);
-
-            Err(response.error.unwrap())
         }
     }
 

src/plants/pnl_plant.rs

@@ -602,7 +602,10 @@ impl RithmicPnlPlantHandle {
             .map_err(|_| "Connection closed".to_string())??
             .remove(0);
 
-        if response.error.is_none() {
+        if let Some(err) = response.error {
+            error!("pnl_plant: login failed {:?}", err);
+            Err(err)
+        } else {
             let _ = self.sender.send(PnlPlantCommand::SetLogin).await;
 
             if let RithmicMessage::ResponseLogin(resp) = &response.message {
@@ -619,10 +622,6 @@ impl RithmicPnlPlantHandle {
             info!("pnl_plant: logged in");
 
             Ok(response)
-        } else {
-            error!("pnl_plant: login failed {:?}", response.error);
-
-            Err(response.error.unwrap())
         }
     }
 

src/plants/ticker_plant.rs

@@ -985,7 +985,10 @@ impl RithmicTickerPlantHandle {
             .map_err(|_| "Connection closed".to_string())??
             .remove(0);
 
-        if response.error.is_none() {
+        if let Some(err) = response.error {
+            error!("ticker_plant: login failed {:?}", err);
+            Err(err)
+        } else {
             let _ = self.sender.send(TickerPlantCommand::SetLogin).await;
 
             if let RithmicMessage::ResponseLogin(resp) = &response.message {
@@ -1002,10 +1005,6 @@ impl RithmicTickerPlantHandle {
             info!("ticker_plant: logged in");
 
             Ok(response)
-        } else {
-            error!("ticker_plant: login failed {:?}", response.error);
-
-            Err(response.error.unwrap())
         }
     }