fix(client): isolate per-userkey failures in resolveUserKeysInHtml (#129)

Switch from Promise.all to Promise.allSettled when fetching user info for
ri:user references. A single rejected getUserByKey call previously aborted
resolution for the entire page; now each failure falls back to the raw
userkey (matching getUserByKey's own caught-error fallback) without
affecting the other resolutions.

Add a regression test that spies on getUserByKey to force one rejection
alongside one success and verifies partial replacement still happens.

Author: pchuri

lib/confluence-client.js

@@ -496,14 +496,23 @@ class ConfluenceClient {
       return { html, userMap: new Map() };
     }
 
-    // Fetch user info for all keys in parallel
-    const userPromises = Array.from(userKeys).map(key => this.getUserByKey(key));
-    const users = await Promise.all(userPromises);
+    // Fetch user info for all keys in parallel; isolate per-key failures so a
+    // single rejection doesn't drop display names for the rest of the page.
+    const keysArray = Array.from(userKeys);
+    const results = await Promise.allSettled(
+      keysArray.map(key => this.getUserByKey(key))
+    );
 
-    // Build userkey -> displayName map
+    // Build userkey -> displayName map. On rejection, fall back to the raw
+    // userkey (mirrors getUserByKey's own caught-error fallback).
     const userMap = new Map();
-    users.forEach(user => {
-      userMap.set(user.key, user.displayName);
+    results.forEach((result, i) => {
+      const key = keysArray[i];
+      if (result.status === 'fulfilled') {
+        userMap.set(result.value.key, result.value.displayName);
+      } else {
+        userMap.set(key, key);
+      }
     });
 
     // Replace userkey references with display names in HTML

tests/confluence-client.test.js

@@ -1268,6 +1268,26 @@ describe('ConfluenceClient', () => {
       expect(resolved).toBe(html);
       expect(userMap.size).toBe(0);
     });
+
+    test('should isolate per-key failures: one rejection does not drop other resolutions', async () => {
+      const spy = jest.spyOn(client, 'getUserByKey').mockImplementation(async (key) => {
+        if (key === 'good') {
+          return { key, displayName: 'Good User', username: 'good' };
+        }
+        throw new Error('synthetic failure');
+      });
+
+      const html =
+        '<p><ac:link><ri:user ri:userkey="good" /></ac:link> and ' +
+        '<ac:link><ri:user ri:userkey="bad" /></ac:link></p>';
+      const { html: resolved, userMap } = await client.resolveUserKeysInHtml(html);
+
+      expect(resolved).toBe('<p>@Good User and @bad</p>');
+      expect(userMap.get('good')).toBe('Good User');
+      expect(userMap.get('bad')).toBe('bad');
+
+      spy.mockRestore();
+    });
   });
 
   describe('page creation and updates', () => {