refactor: move some imports of commands/venv into type checking#3725
Merged
frostming merged 4 commits intopdm-project:mainfrom Jan 21, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3725 +/- ##
==========================================
+ Coverage 85.91% 85.92% +0.01%
==========================================
Files 118 118
Lines 12372 12364 -8
Branches 2061 2058 -3
==========================================
- Hits 10629 10624 -5
+ Misses 1170 1169 -1
+ Partials 573 571 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
frostming
approved these changes
Jan 21, 2026
Collaborator
|
Thank you for working on this. |
intelfx
added a commit
to intelfx/pdm
that referenced
this pull request
Jan 28, 2026
…ype checking (pdm-project#3725)" This reverts commit 956ff17. That commit converts ternary expressions into if-else chains on grounds of readability, except for one specific case where it does the opposite thus actually hurting readability. Undo this specific hunk.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
news/describing what is new.Describe what you have changed in this PR.
cli/commands/venv/*.pyintoTYPE_CHECKINGin order to improve startup speedruff check --extend-select=SIM src/pdm/cli/commands/venv