Rename IsReplicationEnabled to be consistent with EnableRemoteCluster… (temporalio#8737)

…Connection

## What changed?
Rename to be consistent from
temporalio#8658

## Why?
The inconsistent naming looks wack

## How did you test it?
- [x] built
- [ ] run locally and tested manually
- [x] covered by existing tests
- [ ] added new unit test(s)
- [ ] added new functional test(s)

## Potential risks
NA, field unused

Author: michaely520

api/adminservice/v1/request_response.pb.go

@@ -285,8 +285,8 @@ message AddOrUpdateRemoteClusterRequest {
   string frontend_address = 1;
   bool enable_remote_cluster_connection = 2;
   string frontend_http_address = 3 [deprecated = true];
-  // is_replication_enabled controls whether replication streams are active.
-  bool is_replication_enabled = 4;
+  // enable_replication controls whether replication streams are active.
+  bool enable_replication = 4;
 }
 
 message AddOrUpdateRemoteClusterResponse {

proto/internal/temporal/server/api/adminservice/v1/request_response.proto

@@ -1235,7 +1235,7 @@ func (adh *AdminHandler) AddOrUpdateRemoteCluster(
 			InitialFailoverVersion:   resp.GetInitialFailoverVersion(),
 			IsGlobalNamespaceEnabled: resp.GetIsGlobalNamespaceEnabled(),
 			IsConnectionEnabled:      request.GetEnableRemoteClusterConnection(),
-			IsReplicationEnabled:     request.GetIsReplicationEnabled(),
+			IsReplicationEnabled:     request.GetEnableReplication(),
 			Tags:                     resp.GetTags(),
 		},
 		Version: updateRequestVersion,

service/frontend/admin_handler.go

@@ -158,7 +158,7 @@ func (s *xdcBaseSuite) setupSuite(opts ...testcore.TestClusterOption) {
 						FrontendAddress:               remoteC.Host().RemoteFrontendGRPCAddress(),
 						FrontendHttpAddress:           remoteC.Host().FrontendHTTPAddress(),
 						EnableRemoteClusterConnection: true,
-						IsReplicationEnabled:          true,
+						EnableReplication:             true,
 					})
 				s.Require().NoError(err)
 			}

tests/xdc/base.go

@@ -155,7 +155,7 @@ func (s *ReplicationEnableTestSuite) TestReplicationEnableFlow() {
 			FrontendAddress:               standbyCluster.Host().RemoteFrontendGRPCAddress(),
 			FrontendHttpAddress:           standbyCluster.Host().FrontendHTTPAddress(),
 			EnableRemoteClusterConnection: true,
-			IsReplicationEnabled:          false,
+			EnableReplication:             false,
 		})
 	s.Require().NoError(err)
 
@@ -165,7 +165,7 @@ func (s *ReplicationEnableTestSuite) TestReplicationEnableFlow() {
 			FrontendAddress:               activeCluster.Host().RemoteFrontendGRPCAddress(),
 			FrontendHttpAddress:           activeCluster.Host().FrontendHTTPAddress(),
 			EnableRemoteClusterConnection: true,
-			IsReplicationEnabled:          false,
+			EnableReplication:             false,
 		})
 	s.Require().NoError(err)
 
@@ -254,7 +254,7 @@ func (s *ReplicationEnableTestSuite) TestReplicationEnableFlow() {
 			FrontendAddress:               standbyCluster.Host().RemoteFrontendGRPCAddress(),
 			FrontendHttpAddress:           standbyCluster.Host().FrontendHTTPAddress(),
 			EnableRemoteClusterConnection: true,
-			IsReplicationEnabled:          true, // NOW enable replication
+			EnableReplication:             true, // NOW enable replication
 		})
 	s.Require().NoError(err)
 
@@ -265,7 +265,7 @@ func (s *ReplicationEnableTestSuite) TestReplicationEnableFlow() {
 			FrontendAddress:               activeCluster.Host().RemoteFrontendGRPCAddress(),
 			FrontendHttpAddress:           activeCluster.Host().FrontendHTTPAddress(),
 			EnableRemoteClusterConnection: true,
-			IsReplicationEnabled:          true, // NOW enable replication
+			EnableReplication:             true, // NOW enable replication
 		})
 	s.Require().NoError(err)
 
@@ -302,7 +302,7 @@ func (s *ReplicationEnableTestSuite) TestReplicationEnableFlow() {
 			FrontendAddress:               standbyCluster.Host().RemoteFrontendGRPCAddress(),
 			FrontendHttpAddress:           standbyCluster.Host().FrontendHTTPAddress(),
 			EnableRemoteClusterConnection: true,
-			IsReplicationEnabled:          false, // Disable replication
+			EnableReplication:             false, // Disable replication
 		})
 	s.Require().NoError(err)
 
@@ -313,7 +313,7 @@ func (s *ReplicationEnableTestSuite) TestReplicationEnableFlow() {
 			FrontendAddress:               activeCluster.Host().RemoteFrontendGRPCAddress(),
 			FrontendHttpAddress:           activeCluster.Host().FrontendHTTPAddress(),
 			EnableRemoteClusterConnection: true,
-			IsReplicationEnabled:          false, // Disable replication
+			EnableReplication:             false, // Disable replication
 		})
 	s.Require().NoError(err)