Log errors when doing version compatibility check for Cassandra and SQL (temporalio#8100)

## What changed?
Changes version compability checks to pass the real logger, so that the
error messages would be seeing in the log

## Why?

Before, the error was generic and there were no logs indicating the real
error (see temporalio#7939):
```
sql schema version compatibility check failed: unable to read DB schema version keyspace/database: temporal error: no usable database connection found
```

With this change, the log would contain the actual error:
```
{"level":"error","ts":"2025-07-25T15:30:49.660-0700","msg":"sql handle: unable to refresh database connection pool","error":"pq: no pg_hba.conf entry for host \"127.0.0.1\", ...
```

The alternative solution would be to return the error, but the design of
common/persistence/sql/sqlplugin/db_handle.go suggests we hold the
abstraction boundaries, by returning generic errors and logging specific
errors.

## How did you test it?
- [X] built
- [X] run locally and tested manually
- [X] covered by existing tests

Author: simvlad

common/persistence/cassandra/version_checker.go

@@ -19,21 +19,19 @@ import (
 func VerifyCompatibleVersion(
 	cfg config.Persistence,
 	r resolver.ServiceResolver,
+	logger log.Logger,
 ) error {
-
-	if err := checkMainKeyspace(cfg, r); err != nil {
-		return err
-	}
-	return nil
+	return checkMainKeyspace(cfg, r, logger)
 }
 
 func checkMainKeyspace(
 	cfg config.Persistence,
 	r resolver.ServiceResolver,
+	logger log.Logger,
 ) error {
 	ds, ok := cfg.DataStores[cfg.DefaultStore]
 	if ok && ds.Cassandra != nil {
-		return CheckCompatibleVersion(*ds.Cassandra, r, cassandraschema.Version)
+		return CheckCompatibleVersion(*ds.Cassandra, r, cassandraschema.Version, logger)
 	}
 	return nil
 }
@@ -43,13 +41,14 @@ func CheckCompatibleVersion(
 	cfg config.Cassandra,
 	r resolver.ServiceResolver,
 	expectedVersion string,
+	logger log.Logger,
 ) error {
 
 	session, err := commongocql.NewSession(
 		func() (*gocql.ClusterConfig, error) {
 			return commongocql.NewCassandraCluster(cfg, r)
 		},
-		log.NewNoopLogger(),
+		logger,
 		metrics.NoopMetricsHandler,
 	)
 	if err != nil {

common/persistence/sql/version_checker.go

@@ -13,35 +13,38 @@ import (
 func VerifyCompatibleVersion(
 	cfg config.Persistence,
 	r resolver.ServiceResolver,
+	logger log.Logger,
 ) error {
 
-	if err := checkMainDatabase(cfg, r); err != nil {
+	if err := checkMainDatabase(cfg, r, logger); err != nil {
 		return err
 	}
 	if cfg.VisibilityConfigExist() {
-		return checkVisibilityDatabase(cfg, r)
+		return checkVisibilityDatabase(cfg, r, logger)
 	}
 	return nil
 }
 
 func checkMainDatabase(
 	cfg config.Persistence,
 	r resolver.ServiceResolver,
+	logger log.Logger,
 ) error {
 	ds, ok := cfg.DataStores[cfg.DefaultStore]
 	if ok && ds.SQL != nil {
-		return checkCompatibleVersion(ds.SQL, r, sqlplugin.DbKindMain)
+		return checkCompatibleVersion(ds.SQL, r, sqlplugin.DbKindMain, logger)
 	}
 	return nil
 }
 
 func checkVisibilityDatabase(
 	cfg config.Persistence,
 	r resolver.ServiceResolver,
+	logger log.Logger,
 ) error {
 	ds, ok := cfg.DataStores[cfg.VisibilityStore]
 	if ok && ds.SQL != nil {
-		return checkCompatibleVersion(ds.SQL, r, sqlplugin.DbKindVisibility)
+		return checkCompatibleVersion(ds.SQL, r, sqlplugin.DbKindVisibility, logger)
 	}
 	return nil
 }
@@ -50,8 +53,9 @@ func checkCompatibleVersion(
 	cfg *config.SQL,
 	r resolver.ServiceResolver,
 	dbKind sqlplugin.DbKind,
+	logger log.Logger,
 ) error {
-	db, err := NewSQLAdminDB(dbKind, cfg, r, log.NewNoopLogger(), metrics.NoopMetricsHandler)
+	db, err := NewSQLAdminDB(dbKind, cfg, r, logger, metrics.NoopMetricsHandler)
 	if err != nil {
 		return err
 	}

temporal/fx.go

@@ -166,20 +166,20 @@ func ServerOptionsProvider(opts []ServerOption) (serverOptionsProvider, error) {
 		return serverOptionsProvider{}, err
 	}
 
+	// Logger
+	logger := so.logger
+	if logger == nil {
+		logger = log.NewZapLogger(log.BuildZapLogger(so.config.Log))
+	}
+
 	persistenceConfig := so.config.Persistence
-	err = verifyPersistenceCompatibleVersion(persistenceConfig, so.persistenceServiceResolver)
+	err = verifyPersistenceCompatibleVersion(persistenceConfig, so.persistenceServiceResolver, logger)
 	if err != nil {
 		return serverOptionsProvider{}, err
 	}
 
 	stopChan := make(chan interface{})
 
-	// Logger
-	logger := so.logger
-	if logger == nil {
-		logger = log.NewZapLogger(log.BuildZapLogger(so.config.Log))
-	}
-
 	// ClientFactoryProvider
 	clientFactoryProvider := so.clientFactoryProvider
 	if clientFactoryProvider == nil {
@@ -829,13 +829,17 @@ func ServerLifetimeHooks(
 	lc.Append(fx.StartStopHook(svr.Start, svr.Stop))
 }
 
-func verifyPersistenceCompatibleVersion(config config.Persistence, persistenceServiceResolver resolver.ServiceResolver) error {
+func verifyPersistenceCompatibleVersion(
+	cfg config.Persistence,
+	persistenceServiceResolver resolver.ServiceResolver,
+	logger log.Logger,
+) error {
 	// cassandra schema version validation
-	if err := cassandra.VerifyCompatibleVersion(config, persistenceServiceResolver); err != nil {
+	if err := cassandra.VerifyCompatibleVersion(cfg, persistenceServiceResolver, logger); err != nil {
 		return fmt.Errorf("cassandra schema version compatibility check failed: %w", err)
 	}
 	// sql schema version validation
-	if err := sql.VerifyCompatibleVersion(config, persistenceServiceResolver); err != nil {
+	if err := sql.VerifyCompatibleVersion(cfg, persistenceServiceResolver, logger); err != nil {
 		return fmt.Errorf("sql schema version compatibility check failed: %w", err)
 	}
 	return nil

tools/cassandra/version_tests.go

@@ -52,7 +52,7 @@ func (s *VersionTestSuite) TestVerifyCompatibleVersion() {
 		},
 		TransactionSizeLimit: dynamicconfig.GetIntPropertyFn(primitives.DefaultTransactionSizeLimit),
 	}
-	s.NoError(cassandra.VerifyCompatibleVersion(cfg, resolver.NewNoopResolver()))
+	s.NoError(cassandra.VerifyCompatibleVersion(cfg, resolver.NewNoopResolver(), log.NewNoopLogger()))
 }
 
 func (s *VersionTestSuite) createKeyspace(keyspace string) func() {

tools/sql/clitest/version_tests.go

@@ -7,6 +7,7 @@ import (
 	"github.com/stretchr/testify/suite"
 	"go.temporal.io/server/common/config"
 	"go.temporal.io/server/common/dynamicconfig"
+	"go.temporal.io/server/common/log"
 	persistencetests "go.temporal.io/server/common/persistence/persistence-tests"
 	persistencesql "go.temporal.io/server/common/persistence/sql"
 	"go.temporal.io/server/common/primitives"
@@ -106,7 +107,7 @@ func (s *VersionTestSuite) TestVerifyCompatibleVersion() {
 		},
 		TransactionSizeLimit: dynamicconfig.GetIntPropertyFn(primitives.DefaultTransactionSizeLimit),
 	}
-	s.NoError(persistencesql.VerifyCompatibleVersion(cfg, resolver.NewNoopResolver()))
+	s.NoError(persistencesql.VerifyCompatibleVersion(cfg, resolver.NewNoopResolver(), log.NewNoopLogger()))
 }
 
 func (s *VersionTestSuite) createDatabase(database string) func() {