Commit 50698f6
authored
versioning flakes pt2 (temporalio#7473)
## What changed?
<!-- Describe what has changed in this PR -->
fixed some code to reduce versioning flakes, mainly:
[TestVersioning3FunctionalSuite/TestUnpinnedWorkflowWithRamp_ToUnversioned](https://github.com/temporalio/temporal/actions/runs/13818885947/job/38659266639)
(with_logger data-race ✅)
[TestWorkerDeploymentSuite/TestSetWorkerDeploymentRampingVersion_Unversioned_VersionedCurrent](https://github.com/temporalio/temporal/actions/runs/13818885947/job/38659261367)
( context timeout - maybe fixed by having a separate go-routine ✅ )
[TestDeploymentVersionSuite/TestDrainageStatus_SetCurrentVersion_YesOpenWFs](https://github.com/temporalio/temporal/actions/runs/13818885947/job/38659258964)
(with_logger data-race ✅)
[TestVersioningFunctionalSuite/TestDispatchActivityFailCrossTq (retry
2)](https://github.com/temporalio/temporal/actions/runs/13712084173/job/38350437309)
(with_logger data-race ✅)
## Why?
<!-- Tell your future self why have you made these changes -->
- To stop these from appearing as flakes in the test reports.
## How did you test it?
<!-- How have you verified this change? Tested locally? Added a unit
test? Checked in staging env? -->
- Ran this locally with `-race` and now see no errors (errored out
previously)
- Ran this on CI a bunch of times without errors/flakes
## Potential risks
<!-- Assuming the worst case, what can be broken when deploying this
change to production? -->
## Documentation
<!-- Have you made sure this change doesn't falsify anything currently
stated in `docs/`? If significant
new behavior is added, have you described that in `docs/`? -->
## Is hotfix candidate?
<!-- Is this PR a hotfix candidate or does it require a notification to
be sent to the broader community? (Yes/No) -->1 parent d2aab9d commit 50698f6
2 files changed
+7
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
49 | 49 | | |
50 | 50 | | |
51 | 51 | | |
52 | | - | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
53 | 57 | | |
54 | 58 | | |
55 | 59 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1037 | 1037 | | |
1038 | 1038 | | |
1039 | 1039 | | |
1040 | | - | |
| 1040 | + | |
| 1041 | + | |
1041 | 1042 | | |
1042 | 1043 | | |
1043 | 1044 | | |
| |||
0 commit comments