Skip to content

Commit 76e7417

Browse files
authored
Increase OTEL_BSP_SCHEDULE_DELAY (temporalio#7520)
## What changed? <!-- Describe what has changed in this PR --> Increased OTEL_BSP_SCHEDULE_DELAY from 0 to 100ms. ## Why? <!-- Tell your future self why have you made these changes --> Zero is too aggressive and leads to too much CPU usage. ## How did you test it? <!-- How have you verified this change? Tested locally? Added a unit test? Checked in staging env? --> ## Potential risks <!-- Assuming the worst case, what can be broken when deploying this change to production? --> ## Documentation <!-- Have you made sure this change doesn't falsify anything currently stated in `docs/`? If significant new behavior is added, have you described that in `docs/`? --> ## Is hotfix candidate? <!-- Is this PR a hotfix candidate or does it require a notification to be sent to the broader community? (Yes/No) -->
1 parent 6924604 commit 76e7417

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

Makefile

+1-1
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ GOINSTALL := GOBIN=$(ROOT)/$(LOCALBIN) go install
7474

7575
OTEL ?= false
7676
ifeq ($(OTEL),true)
77-
export OTEL_BSP_SCHEDULE_DELAY=0
77+
export OTEL_BSP_SCHEDULE_DELAY=100 # in ms
7878
export OTEL_EXPORTER_OTLP_TRACES_INSECURE=true
7979
export OTEL_TRACES_EXPORTER=otlp
8080
export TEMPORAL_OTEL_DEBUG=true

docs/development/testing.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ will ultimately fail the test.
9797
To debug your test by analysing observability traces, set the following environment variables:
9898

9999
```bash
100-
export OTEL_BSP_SCHEDULE_DELAY=0
100+
export OTEL_BSP_SCHEDULE_DELAY=100
101101
export OTEL_EXPORTER_OTLP_TRACES_INSECURE=true
102102
export OTEL_TRACES_EXPORTER=otlp
103103
export TEMPORAL_OTEL_DEBUG=true

0 commit comments

Comments
 (0)