Skip to content

Commit 795bbbd

Browse files
authored
Refactor: run archival tests in parallel with others (temporalio#7108)
## What changed? <!-- Describe what has changed in this PR --> Refactor: run archival tests in parallel with others. ## Why? <!-- Tell your future self why have you made these changes --> After previous archival test refactoring it is now possible to run them in parallel. ## How did you test it? <!-- How have you verified this change? Tested locally? Added a unit test? Checked in staging env? --> Run tests. ## Potential risks <!-- Assuming the worst case, what can be broken when deploying this change to production? --> No risks. ## Documentation <!-- Have you made sure this change doesn't falsify anything currently stated in `docs/`? If significant new behavior is added, have you described that in `docs/`? --> No. ## Is hotfix candidate? <!-- Is this PR a hotfix candidate or does it require a notification to be sent to the broader community? (Yes/No) --> No.
1 parent faabd96 commit 795bbbd

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

tests/archival_test.go

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -72,9 +72,8 @@ type (
7272
)
7373

7474
func TestArchivalSuite(t *testing.T) {
75-
// TODO: archival doesn't support parallel yet: t.Parallel()
76-
s := new(ArchivalSuite)
77-
suite.Run(t, s)
75+
t.Parallel() // This suite can work in parallel as long as it is the only one that use testcore.WithArchivalEnabled() option.
76+
suite.Run(t, new(ArchivalSuite))
7877
}
7978

8079
func (s *ArchivalSuite) SetupSuite() {

0 commit comments

Comments
 (0)