Wrong index used for search in case another builder is initialises before the query is completed

[sash]

Here is the setup:

1. A builder on model A is initialised. The connection gets the index name (Model => newBaseQueryBuilder).
2. Another builder for Model B is initialised
3. The original builder performs a query

The model B index is used by the builder of model A since the connection is a shared resource

Proposed solution - use the builder->from to set the index to the builder on initialisation and then use that to set the connection index right before read/write

[sash]

Here is a patch that I use to go around this problem. Im not sure if that is the best solution :)

--- src/Query/Builder.php.original	2025-02-05 09:20:44
+++ src/Query/Builder.php	2025-02-05 09:22:23
@@ -78,6 +78,10 @@
         $this->processor = $processor;
 
     }
+    public function setIndex($value)
+    {
+        $this->index = $value;
+    }
 
 
     public function setRefresh($value)
@@ -463,6 +467,10 @@
             throw new RuntimeException('Groups are not used');
         }
 
+        if ($this->index){
+            $this->connection->setIndex($this->index);
+        }
+
         if ($this->aggregate) {
             $function = $this->aggregate['function'];
             $aggColumns = $this->aggregate['columns'];
--- src/Eloquent/Model.php.original	2025-02-05 09:20:50
+++ src/Eloquent/Model.php	2025-02-05 09:20:58
@@ -394,7 +394,9 @@
         $connection->setMaxSize($this->getMaxSize());
 
 
-        return new QueryBuilder($connection, $connection->getPostProcessor());
+        $builder = new QueryBuilder($connection, $connection->getPostProcessor());
+        $builder->setIndex($this->getTable());
+        return $builder;
     }
 
     /**

[pdphilip]

Hey @sash, please share an example of your original code that produced this issue so I can test my end. Thanks!

[pdphilip]

@sash - I'm in the process of redoing the Elasticsearch version of this package. Once done, I'll bring in all those upgrades here. This issue will be resolved in the upgrade.

[pdphilip]

@sash -v3 has been released, and this issue should be resolved.

Note, v3 is a package re-write and brings in significant breaking changes, please review the upgrade guide carefully: https://opensearch.pdphilip.com/upgrade-guide

[sash]

thanks for your effort! I will try to upgrade the solution and remove any patches that I have to see if the issue is resolved in the next weeks!