fix(album-color-theme): improve theming consistency across UI elements#4109
Merged
Su-Yong merged 3 commits intoDec 1, 2025
Merged
Conversation
- Add theming for search bar background - Add theming for popup/dialog backgrounds (toast, paper-dialog) - Add theming for seekbar with gradient colors (toggleable via config) - Add theming for inverted background elements (affects like/dislike icons) - Refactor types (Config, Renderer) for better type safety - Fix getMixedColor binding issue in updateColor method - Add i18n support for enable-seekbar option (en, ko) Closes pear-devs#2232
Su-Yong
reviewed
Nov 30, 2025
…o helper function
Su-Yong
requested changes
Dec 1, 2025
…single loop Move background, ytmusic-background, and themed properties into variableMap and use colorKeyMap/ratioMap to control their behavior, eliminating code duplication.
Su-Yong
approved these changes
Dec 1, 2025
Collaborator
|
LGTM. I'll be merge it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves the
Album Color Themeplugin by extending theming support to previously unthemed UI elements.Changes
Config,Renderer) for better type safetyScreenshots
New Option
A new toggle has been added to enable/disable seekbar theming:
Closes #2232