Merge pull request #17 from duboism/use_php_8

Convert the test suite to PHPUnitPolyFills and update to PHP 8

Author: ashnazg

.github/workflows/main.yaml

@@ -23,7 +23,7 @@ jobs:
     strategy:
       matrix:
         operating-system: ['ubuntu-latest', 'macos-latest'] #, 'windows-latest']
-        php-versions: ['5.6', '7.0', '7.1', '7.2', '7.3', '7.4']
+        php-versions: ['5.6', '7.0', '7.1', '7.2', '7.3', '7.4', '8.0', '8.1', '8.2', '8.3']
     steps:
     - name: Get source code
       uses: actions/checkout@v4

composer.json

@@ -47,6 +47,6 @@
         "pear/pear-core-minimal": "^1.10.1"
     },
     "require-dev": {
-        "phpunit/phpunit": "^4"
+        "yoast/phpunit-polyfills": "^2.0"
     }
 }

package.xml

@@ -60,7 +60,6 @@ There are two classes to use for templating. HTML_Template_IT is used for basic
    <file name="HTML/Template/IT.php" role="php" />
    <file name="HTML/Template/ITX.php" role="php" />
    <file name="HTML/Template/IT_Error.php" role="php" />
-   <file name="tests/AllTests.php" role="test" />
    <file name="tests/ITTest.php" role="test" />
    <file name="tests/ITXTest.php" role="test" />
    <file name="tests/templates/addblock.html" role="test" />

tests/AllTests.php

@@ -1,20 +1,28 @@
 <?php
+
+// As we want to run on PHP < 7.1,
+// we can't use return type declaration in fixtures.
+// Therefore we use PHPUnitPolyFills snakecase fixtures set_up/tear_down
+// instead of setUp/tearDown.
+// See https://github.com/Yoast/PHPUnit-Polyfills?tab=readme-ov-file#option-1-yoastphpunitpolyfillstestcasestestcase
+use Yoast\PHPUnitPolyfills\TestCases\TestCase;
+
 require_once 'HTML/Template/IT.php';
 
-class ITTest extends PHPUnit_Framework_TestCase
+class ITTest extends Yoast\PHPUnitPolyfills\TestCases\TestCase
 {
    /**
     * An HTML_Template_IT object
     * @var object
     */
     var $tpl;
 
-    function setUp()
+    protected function set_up()
     {
         $this->tpl = new HTML_Template_IT(dirname(__FILE__) . '/templates');
     }
 
-    function tearDown()
+    protected function tear_down()
     {
         unset($this->tpl);
     }

tests/ITTest.php

@@ -23,7 +23,7 @@ static function _numberFormatCallback($float, $decimals)
 
 class ITXTest extends ITTest
 {
-    function setUp()
+    function set_up()
     {
         $this->tpl = new HTML_Template_ITX(dirname(__FILE__) . '/templates');
     }