Improve main menu scrolling

[matejdro]

Is there an existing issue for this?

• I have searched the existing issues

Proposed feature request

Main menu scrolling should wrap around e.g. when you reach the top and want to go up, you should reach the bottom and vice versa.

Alternatives

This has some downsides, as mentioned below in the comments, but some good alternatives that alleviate those downsides are also mentioned below.

Anything else?

No response

[ericmigi]

This was done intentionally so that you could let your fingers sit on the bottom button and reliably know that it would get to the last item in the menu

[matejdro]

Hm, would an alternative be to start at the middle of the menu instead? That way this works in both ways and it still has the benefits of wrapping (ability to access more items with just a few button presses)

[Mr-Bajs]

Or if you press down to cycle the bottom and it stops. Once at the bottom you press once and then it starts at the top. In my mind the best of both worlds.

[ericmigi]

worth a try! fyi probably better to use coredevices/pebbleos rather than this repo

[matejdro]

Hm, I thought this was the main repo and the core one was just the fork? It's a bit confusing with so many repos around.

[ericmigi]

Sure, but that's the one we're working from right now. They might sync up in future but who knows what the Rebble folks are up to

[matejdro]

Shouldn't you create PRs into this repo? Rebble folks shouldn't be pulling from you.

[ericmigi]

Why not?

[matejdro]

The way I see it, there are two big reasons:

1. It's not ethical to just yank someone else's code without their permission, even if it's from a fork. Forker should offer the changes back via a pull request

2. It's just not practical. Let's say there are 100 forks of the main repo. Are its maintainers supposed to periodically poll all those forks to see if there are any changes ready to be pulled? Forks making PRs whenever they are ready is way more practical.

[ericmigi]

1. I think as long as the commits are attributed, it should be fine? Isn't that the point of open source - that people can fork, remix etc?

2. Depends on what your definition of main is. Technically the Google repo is the 'main' version? But as of right now the coredevices repo is getting the most updates.

[matejdro]

1. I think most people still prefer to give consent, even when it's legally sound
2. Presumably Google's version is read only? So it cannot be the main version. But yeah, the question whether the Core or the Rebble one is the "main" is legitimate one.

Maybe we continue this on Discord or somewhere else? I think we have went quite off topic.

[MrXANA91]

Don't really know where that conversation went, so I made a PR on both Rebble and CoreDevices repos