From 1cb972ec3b4bec654703d5b1c5abbbddfa8a2e5a Mon Sep 17 00:00:00 2001 From: TrellixVulnTeam Date: Sat, 1 Oct 2022 14:56:07 +0000 Subject: [PATCH 1/2] Adding tarfile member sanitization to extractall() --- pebble_tool/sdk/manager.py | 21 ++++++++++++++++++++- 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/pebble_tool/sdk/manager.py b/pebble_tool/sdk/manager.py index 9f28a70..5a9b0f1 100644 --- a/pebble_tool/sdk/manager.py +++ b/pebble_tool/sdk/manager.py @@ -110,7 +110,26 @@ def _install_from_handle(self, f): raise SDKInstallError("Suspicious version number: {}".format(sdk_info['version'])) Requirements(sdk_info['requirements']).ensure_satisfied() os.mkdir(os.path.join(self.sdk_dir, sdk_info['version'])) - t.extractall(path) + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner) + + + safe_extract(t, path) virtualenv_path = os.path.join(path, ".env") print("Preparing virtualenv... (this may take a while)") subprocess.check_call([sys.executable, "-m", "virtualenv", virtualenv_path, "--no-site-packages"]) From 4a765c9199857f92ca055d90f08f3218dba904bc Mon Sep 17 00:00:00 2001 From: TrellixVulnTeam Date: Tue, 4 Oct 2022 05:19:22 +0000 Subject: [PATCH 2/2] Adding numeric_owner as keyword arguement --- pebble_tool/sdk/manager.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pebble_tool/sdk/manager.py b/pebble_tool/sdk/manager.py index 5a9b0f1..962af8c 100644 --- a/pebble_tool/sdk/manager.py +++ b/pebble_tool/sdk/manager.py @@ -126,7 +126,7 @@ def safe_extract(tar, path=".", members=None, *, numeric_owner=False): if not is_within_directory(path, member_path): raise Exception("Attempted Path Traversal in Tar File") - tar.extractall(path, members, numeric_owner) + tar.extractall(path, members, numeric_owner=numeric_owner) safe_extract(t, path)