Fix remaining Windows build issues: API functions, C++ arrays, and warnings

- Added patch application to minimal build to ensure Fujisan API functions are available
- Fixed C++ variable-length array errors by using std::vector instead
- Fixed macro redefinition warnings with proper #ifndef guards
- Added missing #include <vector> for C++14 compatibility

This addresses:
- Missing libatari800_set_disk_activity_callback and related API functions
- C++ array initialization errors in C++14 mode
- Macro redefinition warnings for Windows defines

Author: pedgarcia

scripts/create-minimal-makefile.sh

@@ -21,6 +21,17 @@ fi
 echo "Creating minimal Makefile for libatari800..."
 echo "This approach avoids autotools and problematic modules like XEP80"
 
+# Ensure Fujisan patches are applied for required API functions
+if [ -d "fujisan-patches" ] && [ -f "fujisan-patches/apply-patches.sh" ]; then
+    echo "Applying Fujisan patches for API functions..."
+    cd fujisan-patches
+    chmod +x apply-patches.sh
+    ./apply-patches.sh || echo "Patches may already be applied"
+    cd ..
+else
+    echo "Warning: Fujisan patches not found - some API functions may be missing"
+fi
+
 # Create a basic Makefile that compiles the essential files for libatari800
 cat > Makefile << 'EOF'
 # Minimal Makefile for libatari800

src/atariemulator.cpp

@@ -21,6 +21,7 @@
 #include <QDateTime>
 #include <QFile>
 #include <cstring>  // for memset
+#include <vector>   // for std::vector
 
 extern "C" {
 #ifdef NETSIO
@@ -243,7 +244,7 @@ bool AtariEmulator::initializeWithDisplayConfig(bool basicEnabled, const QString
         argBytes.append(arg.toUtf8());
     }
 
-    char* args[argBytes.size() + 1];
+    std::vector<char*> args(argBytes.size() + 1);
     for (int i = 0; i < argBytes.size(); ++i) {
         args[i] = argBytes[i].data();
     }
@@ -254,7 +255,7 @@ bool AtariEmulator::initializeWithDisplayConfig(bool basicEnabled, const QString
     qDebug() << "Number of arguments:" << argBytes.size();
     qDebug() << "Note: Display parameters excluded due to libatari800 limitations";
 
-    if (libatari800_init(argBytes.size(), args)) {
+    if (libatari800_init(argBytes.size(), args.data())) {
         qDebug() << "✓ Emulator initialized successfully";
         qDebug() << "  Display settings saved to profile but not applied (requires full SDL atari800)";
         m_targetFps = libatari800_get_fps();
@@ -413,7 +414,7 @@ bool AtariEmulator::initializeWithInputConfig(bool basicEnabled, const QString&
         argBytes.append(arg.toUtf8());
     }
 
-    char* args[argBytes.size() + 1];
+    std::vector<char*> args(argBytes.size() + 1);
     for (int i = 0; i < argBytes.size(); ++i) {
         args[i] = argBytes[i].data();
     }
@@ -425,7 +426,7 @@ bool AtariEmulator::initializeWithInputConfig(bool basicEnabled, const QString&
     qDebug() << "Keyboard Joystick 0 (Numpad + RCtrl):" << (kbdJoy0Enabled ? "ENABLED" : "DISABLED");
     qDebug() << "Keyboard Joystick 1 (WASD + LCtrl):" << (kbdJoy1Enabled ? "ENABLED" : "DISABLED");
 
-    if (libatari800_init(argBytes.size(), args)) {
+    if (libatari800_init(argBytes.size(), args.data())) {
         qDebug() << "✓ Emulator initialized successfully with input settings";
 
 #ifdef GUI_SDL

src/windows_compat.h

@@ -10,15 +10,33 @@
 #endif
 
 // Prevent common macro conflicts
+#ifndef WIN32_LEAN_AND_MEAN
 #define WIN32_LEAN_AND_MEAN
+#endif
+#ifndef NOMINMAX
 #define NOMINMAX
+#endif
+#ifndef NOSERVICE
 #define NOSERVICE
+#endif
+#ifndef NOMCX
 #define NOMCX
+#endif
+#ifndef NOIME
 #define NOIME
+#endif
+#ifndef NOKANJI
 #define NOKANJI
+#endif
+#ifndef NOHELP
 #define NOHELP
+#endif
+#ifndef NOPROFILER
 #define NOPROFILER
+#endif
+#ifndef NODEFERWINDOWPOS
 #define NODEFERWINDOWPOS
+#endif
 
 // Include Windows headers first to prevent conflicts
 #include <windows.h>