Major fix: Use official MSYS2 GitHub Action for proper autotools setup

- Replace manual MSYS2 installation with msys2/setup-msys2@v2 action
- Install complete base-devel group with all autotools
- Add proper MSYS2 shell for verification steps
- Update CMakeLists.txt to find MSYS2 in GitHub Actions location
- Remove explicit PATH manipulation - let setup-msys2 handle environment
- Should finally resolve autotools not found issues

Author: pedgarcia

.github/workflows/build-windows.yml

@@ -33,28 +33,41 @@ jobs:
     - name: Setup MSVC
       uses: microsoft/[email protected]
 
-    - name: Setup build tools
+    - name: Setup MSYS2 with autotools
+      uses: msys2/setup-msys2@v2
+      with:
+        msystem: MSYS
+        install: >-
+          base-devel
+          autoconf
+          automake
+          libtool
+          make
+          pkgconf
+          autoconf-archive
+          mingw-w64-x86_64-gcc
+          mingw-w64-x86_64-binutils
+          mingw-w64-x86_64-pkg-config
+        update: true
+        
+    - name: Install NSIS
       run: |
         # Install NSIS for installer creation
         choco install nsis -y
-        # Install MSYS2 for Unix tools (needed for atari800 autotools build)
-        choco install msys2 -y
-        # Initialize MSYS2 and install required packages for atari800 build
-        C:\tools\msys64\usr\bin\bash.exe -lc "pacman -Syu --noconfirm"
-        C:\tools\msys64\usr\bin\bash.exe -lc "pacman -S --noconfirm autoconf automake make pkgconf libtool autoconf-archive mingw-w64-x86_64-gcc mingw-w64-x86_64-binutils mingw-w64-x86_64-pkg-config"
-        # Add tools to PATH
+        # Add NSIS to PATH
         echo "C:\Program Files (x86)\NSIS" >> $GITHUB_PATH
-        echo "C:\tools\msys64\usr\bin" >> $GITHUB_PATH
-        echo "C:\tools\msys64\mingw64\bin" >> $GITHUB_PATH
 
     - name: Verify MSYS2 setup
+      shell: msys2 {0}
       run: |
         # Verify MSYS2 tools are available
-        C:\tools\msys64\usr\bin\bash.exe -lc "which gcc && gcc --version"
-        C:\tools\msys64\usr\bin\bash.exe -lc "which make && make --version"
-        C:\tools\msys64\usr\bin\bash.exe -lc "which autoconf && autoconf --version"
-        C:\tools\msys64\usr\bin\bash.exe -lc "which aclocal && aclocal --version"
-        C:\tools\msys64\usr\bin\bash.exe -lc "which automake && automake --version"
+        echo "=== Checking MSYS2 Tools ==="
+        which gcc && gcc --version | head -1
+        which make && make --version | head -1
+        which autoconf && autoconf --version | head -1
+        which aclocal && aclocal --version | head -1
+        which automake && automake --version | head -1
+        echo "=== MSYS2 Setup Complete ==="
 
     - name: Create build directory
       run: mkdir build-release

CMakeLists.txt

@@ -51,13 +51,19 @@ set(ATARI800_LIBRARY "${ATARI800_SOURCE_DIR}/src/libatari800.a")
 # Configure platform-specific build commands for atari800
 if(WIN32)
     # Windows: Use MSYS2 environment for building atari800
-    find_program(MSYS2_BASH bash.exe PATHS "C:/tools/msys64/usr/bin" "C:/msys64/usr/bin" DOC "MSYS2 bash executable")
+    # The setup-msys2 GitHub Action creates MSYS2 at D:/a/_temp/msys64
+    find_program(MSYS2_BASH bash.exe PATHS 
+        "D:/a/_temp/msys64/usr/bin" 
+        "C:/tools/msys64/usr/bin" 
+        "C:/msys64/usr/bin" 
+        DOC "MSYS2 bash executable")
     if(NOT MSYS2_BASH)
         message(FATAL_ERROR "MSYS2 bash not found. Please install MSYS2 or ensure it's in the expected location.")
     endif()
 
-    set(ATARI800_CONFIGURE_COMMAND ${MSYS2_BASH} -l -c "export PATH=/usr/bin:/mingw64/bin:$PATH && cd '<SOURCE_DIR>' && '${CMAKE_CURRENT_SOURCE_DIR}/scripts/configure-atari800.sh' '<SOURCE_DIR>'")
-    set(ATARI800_BUILD_COMMAND ${MSYS2_BASH} -l -c "export PATH=/usr/bin:/mingw64/bin:$PATH && cd '<SOURCE_DIR>' && make -j4")
+    message(STATUS "Found MSYS2 bash: ${MSYS2_BASH}")
+    set(ATARI800_CONFIGURE_COMMAND ${MSYS2_BASH} -l -c "cd '<SOURCE_DIR>' && '${CMAKE_CURRENT_SOURCE_DIR}/scripts/configure-atari800.sh' '<SOURCE_DIR>'")
+    set(ATARI800_BUILD_COMMAND ${MSYS2_BASH} -l -c "cd '<SOURCE_DIR>' && make -j4")
 else()
     # Unix/macOS: Use native tools
     set(ATARI800_CONFIGURE_COMMAND ${CMAKE_CURRENT_SOURCE_DIR}/scripts/configure-atari800.sh <SOURCE_DIR>)