Fix Windows build MSBuild integration issues

- Remove invalid CMake generator expressions from verification commands
- Add MinGW gcc to PATH in MSYS2 environment for proper toolchain access
- Enhance MSYS2 setup verification with detailed compiler detection
- Fix PATH configuration in all MSYS2 build commands

This resolves the two critical issues identified from GitHub Actions logs:
1. CMake configuration errors with TARGET_EXISTS on file paths
2. gcc not accessible in MSYS environment despite MinGW installation

Author: pedgarcia

.github/workflows/build-windows.yml

@@ -60,13 +60,22 @@ jobs:
     - name: Verify MSYS2 setup
       shell: msys2 {0}
       run: |
+        # Add MinGW paths to ensure gcc is accessible
+        export PATH="/mingw64/bin:$PATH"
+        
         # Verify MSYS2 tools are available
         echo "=== Checking MSYS2 Tools ==="
-        which gcc && gcc --version | head -1
-        which make && make --version | head -1
-        which autoconf && autoconf --version | head -1
-        which aclocal && aclocal --version | head -1
-        which automake && automake --version | head -1
+        echo "Current PATH: $PATH"
+        which gcc && gcc --version | head -1 || echo "gcc not found in PATH"
+        which make && make --version | head -1 || echo "make not found in PATH"
+        which autoconf && autoconf --version | head -1 || echo "autoconf not found in PATH"
+        which aclocal && aclocal --version | head -1 || echo "aclocal not found in PATH" 
+        which automake && automake --version | head -1 || echo "automake not found in PATH"
+        
+        # List available compilers
+        echo "=== Available GCC compilers ==="
+        ls -la /mingw64/bin/gcc* 2>/dev/null || echo "No MinGW64 GCC found"
+        ls -la /usr/bin/gcc* 2>/dev/null || echo "No MSYS GCC found"
         echo "=== MSYS2 Setup Complete ==="
 
     - name: Create build directory

CMakeLists.txt

@@ -64,9 +64,9 @@ if(WIN32)
 
     message(STATUS "Found MSYS2 bash: ${MSYS2_BASH}")
 
-    # Use msys2 shell environment directly instead of bash -l -c
-    set(ATARI800_CONFIGURE_COMMAND ${CMAKE_COMMAND} -E env MSYSTEM=MSYS ${MSYS2_BASH} --login -c "cd '<SOURCE_DIR>' && '${CMAKE_CURRENT_SOURCE_DIR}/scripts/configure-atari800.sh' '<SOURCE_DIR>'")
-    set(ATARI800_BUILD_COMMAND ${CMAKE_COMMAND} -E env MSYSTEM=MSYS ${MSYS2_BASH} --login -c "cd '<SOURCE_DIR>' && make -j4")
+    # Use msys2 shell environment with proper PATH for MinGW gcc
+    set(ATARI800_CONFIGURE_COMMAND ${CMAKE_COMMAND} -E env MSYSTEM=MSYS ${MSYS2_BASH} --login -c "export PATH='/mingw64/bin:$PATH' && cd '<SOURCE_DIR>' && '${CMAKE_CURRENT_SOURCE_DIR}/scripts/configure-atari800.sh' '<SOURCE_DIR>'")
+    set(ATARI800_BUILD_COMMAND ${CMAKE_COMMAND} -E env MSYSTEM=MSYS ${MSYS2_BASH} --login -c "export PATH='/mingw64/bin:$PATH' && cd '<SOURCE_DIR>' && make -j4")
 else()
     # Unix/macOS: Use native tools
     set(ATARI800_CONFIGURE_COMMAND ${CMAKE_CURRENT_SOURCE_DIR}/scripts/configure-atari800.sh <SOURCE_DIR>)
@@ -116,8 +116,7 @@ if(WIN32)
         COMMAND ${CMAKE_COMMAND} -E echo "=== Verifying libatari800 build on Windows ==="
         COMMAND ${CMAKE_COMMAND} -E echo "Expected library: ${ATARI800_LIBRARY}"
         COMMAND ${CMAKE_COMMAND} -E echo "Checking if library exists..."
-        COMMAND ${CMAKE_COMMAND} -E echo "$<IF:$<BOOL:$<TARGET_EXISTS:${ATARI800_LIBRARY}>>,Library found,Library NOT found>"
-        COMMAND ${MSYS2_BASH} -l -c "if [ -f '${ATARI800_LIBRARY}' ]; then echo 'SUCCESS: libatari800.a exists'; ls -la '${ATARI800_LIBRARY}'; else echo 'ERROR: libatari800.a missing'; ls -la '${ATARI800_SOURCE_DIR}/src/'; fi"
+        COMMAND ${MSYS2_BASH} -l -c "export PATH='/mingw64/bin:$PATH' && if [ -f '${ATARI800_LIBRARY}' ]; then echo 'SUCCESS: libatari800.a exists'; ls -la '${ATARI800_LIBRARY}'; else echo 'ERROR: libatari800.a missing'; ls -la '${ATARI800_SOURCE_DIR}/src/'; fi"
         COMMENT "Verifying libatari800 library creation"
     )
 endif()