refactor(ruby): standardize on StandardRB for consistent formatting

Replace RuboCop with StandardRB across both pre-commit hooks and Neovim
Conform configuration to ensure consistent formatting. This resolves
conflicts where pre-commit and Neovim were applying different formatting
rules to Ruby files.

Changes:
- Replace rubocop hook with standardrb in pre-commit config
- Add standard gem to scripts Gemfile
- Apply StandardRB formatting to git-helpers.rb and gitlab-helpers.rb
- Update Gemfile to use double quotes (StandardRB style)
- Fix lint issues: use next instead of return in iterator, use find instead of filter.first

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

Author: pedropombeiro

.pre-commit-config.yaml

@@ -47,17 +47,6 @@ repos:
         args: ["--config-path", ".config/nvim/.stylua.toml"]
         stages: [manual]
 
-  - repo: https://github.com/rubocop/rubocop
-    rev: v1.82.1
-    hooks:
-      - id: rubocop
-        name: rubocop (check)
-      - id: rubocop
-        name: rubocop (fix)
-        alias: rubocop-fix
-        args: ["-a"]
-        stages: [manual]
-
   - repo: https://github.com/pre-commit/mirrors-prettier
     rev: v3.1.0
     hooks:
@@ -73,6 +62,17 @@ repos:
 
   - repo: local
     hooks:
+      - id: standardrb
+        name: standardrb (check)
+        entry: standardrb
+        language: system
+        types: [ruby]
+      - id: standardrb-fix
+        name: standardrb (fix)
+        entry: standardrb --fix
+        language: system
+        types: [ruby]
+        stages: [manual]
       - id: markdownlint-cli2
         name: markdownlint-cli2
         entry: npx markdownlint-cli2

.shellrc/zshrc.d/functions/scripts/Gemfile

@@ -1,9 +1,10 @@
 # frozen_string_literal: true
 
-ruby '>= 2.6.0'
+ruby ">= 3.4.0"
 
-source 'https://rubygems.org'
+source "https://rubygems.org"
 
-gem 'terminal-table'
-gem 'tty-link'
-gem 'tty-table'
+gem "standard"
+gem "terminal-table"
+gem "tty-link"
+gem "tty-table"

.shellrc/zshrc.d/functions/scripts/git-helpers.rb

@@ -5,7 +5,7 @@
 # this script will ensure that branches from the same MR will be rebased correctly, keeping the chain order
 
 def compute_default_branch
-  system(*%w[git show-ref -q --verify refs/heads/main]) ? 'main' : 'master'
+  system(*%w[git show-ref -q --verify refs/heads/main]) ? "main" : "master"
 end
 
 # compute_parent_branch will determine the closest parent branch,
@@ -15,19 +15,19 @@ def compute_default_branch
 def compute_parent_branch(branch_name = nil)
   branch_name ||= `git rev-parse --abbrev-ref HEAD`
   remote_names = `git remote`.lines.map(&:chomp)
-  active_remote_name = `git rev-parse --abbrev-ref --symbolic-full-name @{u} 2>/dev/null`.split('/').first
+  active_remote_name = `git rev-parse --abbrev-ref --symbolic-full-name @{u} 2>/dev/null`.split("/").first
   other_remote_names = remote_names - [active_remote_name]
 
   parent_branch_line = `git log --decorate --simplify-by-decoration --oneline #{branch_name}`.lines[1].rstrip
   parent_branch_line = parent_branch_line
-                       .sub('HEAD -> ', '')
-                       .gsub(/tag: [^,)]+(, )?/, '')
+    .sub("HEAD -> ", "")
+    .gsub(/tag: [^,)]+(, )?/, "")
   return compute_default_branch if parent_branch_line.match?(%r{.* \((origin|security)/(.*)\) .*})
   return compute_default_branch unless parent_branch_line.match?(/.* \((.*)\) .*/)
 
   parent_branch_line
     .sub(/.* \((.*)\) .*/, '\1')
-    .split(', ')
+    .split(", ")
     .reject { |b| other_remote_names.any? { |remote_name| b.start_with?("#{remote_name}/") } }
     .min_by(&:length) || compute_default_branch
 end
@@ -72,26 +72,26 @@ def rebase_all_per_capture_info(local_branch_info_hash)
   current_branch = `git branch --show-current`.strip
 
   local_branch_info_hash.each do |branch, parent_branch|
-    puts 'Rebasing '.brown + branch.cyan + ' onto '.brown + parent_branch.green + '...'.brown
+    puts "Rebasing ".brown + branch.cyan + " onto ".brown + parent_branch.green + "...".brown
 
     system(*%W[git rev-parse --abbrev-ref --symbolic-full-name #{parent_branch}], out: File::NULL, err: File::NULL)
     unless Process.last_status.success?
-      puts '  Skipping since '.red + parent_branch.green + ' does not exist.'.red
-      return
+      puts "  Skipping since ".red + parent_branch.green + " does not exist.".red
+      next
     end
 
-    system({ 'LEFTHOOK' => '0' }, *%W[git rebase --update-refs --autostash #{parent_branch} #{branch}])
+    system({"LEFTHOOK" => "0"}, *%W[git rebase --update-refs --autostash #{parent_branch} #{branch}])
     next if Process.last_status.success?
 
     auto_generated_files_hash = {
-      'app/workers/all_queues.yml' => %w[bundle exec rake gitlab:sidekiq:all_queues_yml:generate],
-      'config/sidekiq_queues.yml' => %w[bundle exec rake gitlab:sidekiq:sidekiq_queues_yml:generate],
-      'db/structure.sql' => %w[bundle exec scripts/regenerate-schema],
-      'doc/api/graphql/reference/index.md' => %w[bundle exec rake gitlab:graphql:compile_docs],
-      'doc/user/compliance/audit_event_types.md' => %w[bundle exec rake gitlab:audit_event_types:compile_docs],
-      'doc/update/breaking_windows.md' => %w[bundle exec rake gitlab:docs:compile_windows],
-      'doc/update/deprecations.md' => %w[bundle exec rake gitlab:docs:compile_deprecations],
-      'doc/update/removals.md' => %w[bundle exec rake gitlab:docs:compile_removals]
+      "app/workers/all_queues.yml" => %w[bundle exec rake gitlab:sidekiq:all_queues_yml:generate],
+      "config/sidekiq_queues.yml" => %w[bundle exec rake gitlab:sidekiq:sidekiq_queues_yml:generate],
+      "db/structure.sql" => %w[bundle exec scripts/regenerate-schema],
+      "doc/api/graphql/reference/index.md" => %w[bundle exec rake gitlab:graphql:compile_docs],
+      "doc/user/compliance/audit_event_types.md" => %w[bundle exec rake gitlab:audit_event_types:compile_docs],
+      "doc/update/breaking_windows.md" => %w[bundle exec rake gitlab:docs:compile_windows],
+      "doc/update/deprecations.md" => %w[bundle exec rake gitlab:docs:compile_deprecations],
+      "doc/update/removals.md" => %w[bundle exec rake gitlab:docs:compile_removals]
     }
 
     loop do
@@ -112,12 +112,12 @@ def rebase_all_per_capture_info(local_branch_info_hash)
           err = false
         end
 
-      break unless err || system({ 'GIT_EDITOR' => 'true', 'LEFTHOOK' => '0' }, *%w[git rebase --continue])
+      break unless err || system({"GIT_EDITOR" => "true", "LEFTHOOK" => "0"}, *%w[git rebase --continue])
     end
 
     # There is a merge conflict that needs to be resolved by the user, exit now
     system(%(terminal-notifier -title 'rebase_all failed with merge conflict' -message 'Please resolve merge conflicts!' -sound boop -ignoreDnD))
-    return
+    return false
   end
 
   system(*%W[git switch #{current_branch}])
@@ -127,22 +127,22 @@ def rebase_mappings
   system(*%w[git diff-index --quiet HEAD -- . ':!bin/'])
   unless Process.last_status.success?
     system(%(terminal-notifier -title 'rebase_all failed' -message 'Please stash the changes in the current branch before calling rebase_all!' -sound boop -ignoreDnD))
-    abort 'Please stash the changes in the current branch before calling rebase_all!'.red
+    abort "Please stash the changes in the current branch before calling rebase_all!".red
   end
 
-  user_name = ENV.fetch('USER', nil)
+  user_name = ENV.fetch("USER", nil)
   default_branch = compute_default_branch
 
-  mr_pattern       = %r{^(security[-/])?#{user_name}/(?<mr_id>\d+)/[a-z0-9\-+_]+$}i
-  seq_mr_pattern   = %r{^(security[-/])?#{user_name}/(?<mr_id>\d+)/(?<mr_seq_nr>\d+)-[a-z0-9\-+_]+$}i
+  mr_pattern = %r{^(security[-/])?#{user_name}/(?<mr_id>\d+)/[a-z0-9\-+_]+$}i
+  seq_mr_pattern = %r{^(security[-/])?#{user_name}/(?<mr_id>\d+)/(?<mr_seq_nr>\d+)-[a-z0-9\-+_]+$}i
   backport_pattern = %r{^(security[-/])?#{user_name}/(?<mr_id>\d+)/[a-z0-9\-+_]+-(?<milestone>\d+[-.]\d+)$}i
 
   local_branches =
     `git branch --list`
-    .lines
-    .map { |line| line[2..].rstrip }
-    .select { |branch| branch.start_with?("#{user_name}/", "security-#{user_name}/", "security/#{user_name}/") }
-    .sort_by do |branch|
+      .lines
+      .map { |line| line[2..].rstrip }
+      .select { |branch| branch.start_with?("#{user_name}/", "security-#{user_name}/", "security/#{user_name}/") }
+      .sort_by do |branch|
       seq_mr_match_data = seq_mr_pattern.match(branch)
       backport_match_data = backport_pattern.match(branch)
       mr_match_data = mr_pattern.match(branch)
@@ -161,7 +161,7 @@ def rebase_mappings
           branch_distance(branch, default_branch),
           backport_match_data[:mr_id].to_i,
           999, # Put backport branches after sequenced branches
-          backport_match_data[:milestone].tr('.', '-').to_f
+          backport_match_data[:milestone].tr(".", "-").to_f
         ]
       elsif mr_match_data
         [
@@ -193,7 +193,7 @@ def rebase_mappings
     current_mr_seq_nr = nil
 
     if seq_mr_match_data
-      current_mr_id     = seq_mr_match_data[:mr_id]
+      current_mr_id = seq_mr_match_data[:mr_id]
       current_mr_seq_nr = seq_mr_match_data[:mr_seq_nr].to_i
     elsif mr_match_data
       current_mr_id = mr_match_data[:mr_id]
@@ -219,9 +219,9 @@ def rebase_mappings
         rebase_onto = parent_branch
       end
     elsif backport_match_data
-      remote = 'security'
+      remote = "security"
 
-      parent_branch = "#{remote}/#{backport_match_data[:milestone].tr('.', '-')}-stable-ee"
+      parent_branch = "#{remote}/#{backport_match_data[:milestone].tr(".", "-")}-stable-ee"
       rebase_onto = parent_branch
     else
       parent_branch = compute_parent_branch(branch)
@@ -238,22 +238,22 @@ def rebase_mappings
 end
 
 def branch_sort_key(branch_info)
-  [branch_info[:chain_mr_id] || '', branch_info[:chain_mr_seq_nr].nil? ? 0 : -branch_info[:chain_mr_seq_nr]]
+  [branch_info[:chain_mr_id] || "", branch_info[:chain_mr_seq_nr].nil? ? 0 : -branch_info[:chain_mr_seq_nr]]
 end
 
 def branch_distance(branch, parent_branch)
   `git rev-list --count #{parent_branch}..#{branch}`.strip.to_i
 end
 
 def rebase_all
-  require 'json'
+  require "json"
   default_branch = compute_default_branch
   mappings = rebase_mappings
-             .sort { |b1, b2| branch_sort_key(b1) <=> branch_sort_key(b2) }
-             .sort do |b1, b2|
-    branch_distance(b1[:branch],
-                    default_branch) <=> branch_distance(b2[:branch], default_branch)
-  end
+    .sort { |b1, b2| branch_sort_key(b1) <=> branch_sort_key(b2) }
+    .sort do |b1, b2|
+      branch_distance(b1[:branch],
+        default_branch) <=> branch_distance(b2[:branch], default_branch)
+    end
     .to_h { |b| [b[:branch], b[:rebase_onto]] }
   rebase_all_per_capture_info(mappings)
 end
@@ -263,7 +263,7 @@ def git_push_issue(*args)
 
   current_branch = `git branch --show-current`.strip
 
-  user_name = ENV.fetch('USER', nil)
+  user_name = ENV.fetch("USER", nil)
   mr_pattern = %r{^(?<prefix>(security[-/])?#{user_name})/(?<mr_id>\d+)/[a-z0-9\-+_]+$}
   mr_match_data = mr_pattern.match(current_branch)
 
@@ -281,7 +281,7 @@ def git_push_issue(*args)
 
     system(*%W[git rev-parse --abbrev-ref --symbolic-full-name #{parent_branch}], out: File::NULL, err: File::NULL)
     unless Process.last_status.success?
-      puts '  Skipping since '.red + parent_branch.green + ' does not exist.'.red
+      puts "  Skipping since ".red + parent_branch.green + " does not exist.".red
       next
     end
 
@@ -290,9 +290,9 @@ def git_push_issue(*args)
 
   return unless branches.any?
 
-  active_remote_name = `git rev-parse --abbrev-ref --symbolic-full-name @{u} 2>/dev/null`.split('/').first
+  active_remote_name = `git rev-parse --abbrev-ref --symbolic-full-name @{u} 2>/dev/null`.split("/").first
 
-  puts 'Pushing '.brown + branches.map(&:cyan).join(', ') + ' to '.brown + active_remote_name.green + '...'.brown
+  puts "Pushing ".brown + branches.map(&:cyan).join(", ") + " to ".brown + active_remote_name.green + "...".brown
 
   system(*%W[git push --force-with-lease #{active_remote_name}], *branches, *args)
 end
@@ -303,11 +303,11 @@ def changed_branch_files(format: nil)
 
   change_log = `git diff --diff-filter=AM -U0 #{parent_branch}..#{current_branch} | grep -E '^(---|\\+\\+\\+|@@)'`.lines
   changed_files =
-    change_log.reject { |line| line.start_with?('@@') } # discard diff header
-              .map { |line| line.slice(4..-1).chomp }
-              .reject { |file| file == '/dev/null' } # discard deletions
-              .map { |file| file.slice(2..-1) } # discard b/
-              .uniq
+    change_log.reject { |line| line.start_with?("@@") } # discard diff header
+      .map { |line| line.slice(4..-1).chomp }
+      .reject { |file| file == File::NULL } # discard deletions
+      .map { |file| file.slice(2..-1) } # discard b/
+      .uniq
 
   changed_files.map do |file|
     index = change_log.index { |line| line.include?("b/#{file}") }