Push and pray

Author: coladarci

lib/peek_app_sdk/ui/odyssey/activity_picker.ex

@@ -13,14 +13,8 @@ defmodule PeekAppSDK.UI.Odyssey.OdysseyActivityPicker do
   use Phoenix.LiveComponent
   use Phoenix.Component
 
-  @required_assigns ~w(field install_id)a
-
   @impl true
   def mount(socket) do
-    socket =
-      socket
-      |> assign(selection: nil)
-
     {:ok, socket}
   end
 
@@ -59,7 +53,7 @@ defmodule PeekAppSDK.UI.Odyssey.OdysseyActivityPicker do
     ~H"""
     <div phx-hook="OdysseyActivityPicker" id={"#{@id}_hook"}>
       <!-- Hidden input for form value -->
-      <input type="hidden" name={@field.name} value={@selection} />
+      <input type="hidden" name={@field.name} value={process_ids_for_multi_select(@field.value)} />
 
       <!-- Odyssey product picker will be rendered here -->
       <div>
@@ -68,7 +62,8 @@ defmodule PeekAppSDK.UI.Odyssey.OdysseyActivityPicker do
           phx-update="ignore"
           title="Activity Picker"
           phx-target={@myself}
-          ids={@selection}
+          multiple={if(@multiple, do: "true", else: "false")}
+          ids={process_ids_for_multi_select(@field.value)}
           products={Jason.encode!(@products)}
         >
         </odyssey-product-picker>
@@ -77,6 +72,10 @@ defmodule PeekAppSDK.UI.Odyssey.OdysseyActivityPicker do
     """
   end
 
+  defp process_ids_for_multi_select(ids) do
+    ids |> List.wrap() |> Enum.join(",")
+  end
+
   @doc """
   Renders an activity picker component.
 
@@ -85,6 +84,7 @@ defmodule PeekAppSDK.UI.Odyssey.OdysseyActivityPicker do
   """
   attr(:field, :any, required: true, doc: "a Phoenix.HTML.FormField struct")
   attr(:id, :string, doc: "component id, defaults to form_field_activity_picker")
+  attr(:multiple, :boolean, default: false, doc: "whether to allow multiple selections")
   attr(:install_id, :string, required: true, doc: "the install id for the current partner")
 
   def odyssey_activity_picker(assigns) do

test/peek_app_sdk/ui/odyssey/activity_picker_test.exs

@@ -90,6 +90,40 @@ defmodule PeekAppSDK.UI.Odyssey.OdysseyActivityPickerTest do
       assert html =~ ~r/<input[^>]*type="hidden"[^>]*name="my_form\[activity_id\]"[^>]*>/
     end
 
+    test "renders with correct form when a multi-select" do
+      # Mock the GraphQL query response
+      Tesla.Adapter.Finch
+      |> Mimic.stub(:call, fn _env, _opts ->
+        response_data = %{
+          activities: [
+            %{id: "activity_1", name: "Test Activity", colorHex: "#000000"},
+            %{id: "activity_2", name: "Test Activity 2", colorHex: "#000000"}
+          ]
+        }
+
+        {:ok, %Tesla.Env{status: 200, body: %{data: response_data}}}
+      end)
+
+      # Create a form with a pre-selected activity
+      form_data = %{"activity_ids" => ["activity_1", "activity_2"]}
+      form = to_form(form_data, as: :my_form)
+
+      html =
+        render_component(
+          fn assigns ->
+            ~H"""
+            <.form for={@form}>
+              <.odyssey_activity_picker field={@form[:activity_ids]} install_id="test_install_id" />
+            </.form>
+            """
+          end,
+          %{form: form}
+        )
+
+      # Verify the hidden input has the correct name (value starts as nil and gets updated by JS)
+      assert html =~ "ids=\"activity_1,activity_2\""
+    end
+
     test "generates unique component IDs based on form field" do
       # Mock the GraphQL query response
       Tesla.Adapter.Finch