fix tesla warning

Author: martinatpeek

coveralls.json

@@ -4,8 +4,7 @@
     "test/*",
     "lib/peek_app_sdk/application.ex",
     "lib/peek_app_sdk/ui/core_components.ex",
-    "lib/peek_app_sdk/ui/get_text.ex",
-    "lib/peek_app_sdk/metrics.ex"
+    "lib/peek_app_sdk/ui/get_text.ex"
   ],
   "print_summary": true
-}
+}

lib/peek_app_sdk/client.ex

@@ -1,11 +1,18 @@
 defmodule PeekAppSDK.Client do
   require Logger
 
-  use Tesla
-
   alias PeekAppSDK.Config
 
-  plug Tesla.Middleware.JSON, engine_opts: [keys: &String.to_atom/1]
+  @doc """
+  Creates a Tesla client with the appropriate middleware configuration.
+  """
+  def client do
+    middleware = [
+      {Tesla.Middleware.JSON, engine_opts: [keys: &String.to_atom/1]}
+    ]
+
+    Tesla.client(middleware)
+  end
 
   @doc """
   Queries the Peek Pro API.
@@ -37,7 +44,7 @@ defmodule PeekAppSDK.Client do
     operation_name = operation_name(gql_query)
     url = "#{config.peek_api_url |> String.trim()}/#{peek_app_id}/#{operation_name}"
 
-    case request(
+    case Tesla.request(client(),
            method: :post,
            url: url,
            body: body_params,

lib/peek_app_sdk/metrics/client.ex

@@ -1,13 +1,20 @@
 defmodule PeekAppSDK.Metrics.Client do
-  use Tesla
-
   @moduledoc """
   Client for sending metrics to the Peek Pro metrics service.
   """
 
-  plug Tesla.Middleware.JSON
-  plug Tesla.Middleware.Headers, [{"Content-Type", "application/json"}]
-  plug Tesla.Middleware.Retry, delay: 500, max_retries: 10
+  @doc """
+  Creates a Tesla client with the appropriate middleware configuration.
+  """
+  def client do
+    middleware = [
+      Tesla.Middleware.JSON,
+      {Tesla.Middleware.Headers, [{"Content-Type", "application/json"}]},
+      {Tesla.Middleware.Retry, delay: 500, max_retries: 10}
+    ]
+
+    Tesla.client(middleware)
+  end
 
   @doc """
   Tracks an event with the given event ID and payload.
@@ -119,7 +126,7 @@ defmodule PeekAppSDK.Metrics.Client do
     do: "https://ahem.peeklabs.com/events/#{Application.fetch_env!(:peek_app_sdk, :peek_app_id)}"
 
   defp do_post!(body, _opts \\ []) do
-    response = post!(event_url(), body)
+    response = Tesla.post!(client(), event_url(), body)
 
     case response do
       %Tesla.Env{status: 202} ->

lib/peek_app_sdk/ui/core_components.ex

@@ -17,6 +17,7 @@ defmodule PeekAppSDK.UI.CoreComponents do
   use Phoenix.Component
   use Gettext, backend: PeekAppSDK.UI.Gettext
 
+  alias Phoenix.HTML.Form
   alias Phoenix.LiveView.JS
 
   @doc """
@@ -347,7 +348,7 @@ defmodule PeekAppSDK.UI.CoreComponents do
   def input(%{type: "checkbox"} = assigns) do
     assigns =
       assign_new(assigns, :checked, fn ->
-        Phoenix.HTML.Form.normalize_value("checkbox", assigns[:value])
+        Form.normalize_value("checkbox", assigns[:value])
       end)
 
     ~H"""

mix.lock

@@ -6,9 +6,7 @@
   "cowlib": {:hex, :cowlib, "2.15.0", "3c97a318a933962d1c12b96ab7c1d728267d2c523c25a5b57b0f93392b6e9e25", [:make, :rebar3], [], "hexpm", "4f00c879a64b4fe7c8fcb42a4281925e9ffdb928820b03c3ad325a617e857532"},
   "credo": {:hex, :credo, "1.7.12", "9e3c20463de4b5f3f23721527fcaf16722ec815e70ff6c60b86412c695d426c1", [:mix], [{:bunt, "~> 0.2.1 or ~> 1.0", [hex: :bunt, repo: "hexpm", optional: false]}, {:file_system, "~> 0.2 or ~> 1.0", [hex: :file_system, repo: "hexpm", optional: false]}, {:jason, "~> 1.0", [hex: :jason, repo: "hexpm", optional: false]}], "hexpm", "8493d45c656c5427d9c729235b99d498bd133421f3e0a683e5c1b561471291e5"},
   "excoveralls": {:hex, :excoveralls, "0.18.5", "e229d0a65982613332ec30f07940038fe451a2e5b29bce2a5022165f0c9b157e", [:mix], [{:castore, "~> 1.0", [hex: :castore, repo: "hexpm", optional: true]}, {:jason, "~> 1.0", [hex: :jason, repo: "hexpm", optional: false]}], "hexpm", "523fe8a15603f86d64852aab2abe8ddbd78e68579c8525ae765facc5eae01562"},
-  "exjsx": {:hex, :exjsx, "4.0.0", "60548841e0212df401e38e63c0078ec57b33e7ea49b032c796ccad8cde794b5c", [:mix], [{:jsx, "~> 2.8.0", [hex: :jsx, repo: "hexpm", optional: false]}], "hexpm", "32e95820a97cffea67830e91514a2ad53b888850442d6d395f53a1ac60c82e07"},
   "expo": {:hex, :expo, "1.1.0", "f7b9ed7fb5745ebe1eeedf3d6f29226c5dd52897ac67c0f8af62a07e661e5c75", [:mix], [], "hexpm", "fbadf93f4700fb44c331362177bdca9eeb8097e8b0ef525c9cc501cb9917c960"},
-  "exvcr": {:hex, :exvcr, "0.17.1", "3bae83d698a464a48212ad87c8ea4bcfb6bd76d53b937129472764e557616228", [:mix], [{:exjsx, "~> 4.0", [hex: :exjsx, repo: "hexpm", optional: false]}, {:finch, "~> 0.16", [hex: :finch, repo: "hexpm", optional: true]}, {:httpoison, "~> 1.0 or ~> 2.0", [hex: :httpoison, repo: "hexpm", optional: true]}, {:ibrowse, "~> 4.4", [hex: :ibrowse, repo: "hexpm", optional: true]}, {:meck, "~> 1.0", [hex: :meck, repo: "hexpm", optional: false]}], "hexpm", "a39d86980da183011366a878972e0ed43a5441814b701edd2e11360564e7bcab"},
   "file_system": {:hex, :file_system, "1.1.0", "08d232062284546c6c34426997dd7ef6ec9f8bbd090eb91780283c9016840e8f", [:mix], [], "hexpm", "bfcf81244f416871f2a2e15c1b515287faa5db9c6bcf290222206d120b3d43f6"},
   "finch": {:hex, :finch, "0.20.0", "5330aefb6b010f424dcbbc4615d914e9e3deae40095e73ab0c1bb0968933cadf", [:mix], [{:mime, "~> 1.0 or ~> 2.0", [hex: :mime, repo: "hexpm", optional: false]}, {:mint, "~> 1.6.2 or ~> 1.7", [hex: :mint, repo: "hexpm", optional: false]}, {:nimble_options, "~> 0.4 or ~> 1.0", [hex: :nimble_options, repo: "hexpm", optional: false]}, {:nimble_pool, "~> 1.1", [hex: :nimble_pool, repo: "hexpm", optional: false]}, {:telemetry, "~> 0.4 or ~> 1.0", [hex: :telemetry, repo: "hexpm", optional: false]}], "hexpm", "2658131a74d051aabfcba936093c903b8e89da9a1b63e430bee62045fa9b2ee2"},
   "gettext": {:hex, :gettext, "0.26.2", "5978aa7b21fada6deabf1f6341ddba50bc69c999e812211903b169799208f2a8", [:mix], [{:expo, "~> 0.5.1 or ~> 1.0", [hex: :expo, repo: "hexpm", optional: false]}], "hexpm", "aa978504bcf76511efdc22d580ba08e2279caab1066b76bb9aa81c4a1e0a32a5"},
@@ -17,8 +15,6 @@
   "jason": {:hex, :jason, "1.4.4", "b9226785a9aa77b6857ca22832cffa5d5011a667207eb2a0ad56adb5db443b8a", [:mix], [{:decimal, "~> 1.0 or ~> 2.0", [hex: :decimal, repo: "hexpm", optional: true]}], "hexpm", "c5eb0cab91f094599f94d55bc63409236a8ec69a21a67814529e8d5f6cc90b3b"},
   "joken": {:hex, :joken, "2.6.2", "5daaf82259ca603af4f0b065475099ada1b2b849ff140ccd37f4b6828ca6892a", [:mix], [{:jose, "~> 1.11.10", [hex: :jose, repo: "hexpm", optional: false]}], "hexpm", "5134b5b0a6e37494e46dbf9e4dad53808e5e787904b7c73972651b51cce3d72b"},
   "jose": {:hex, :jose, "1.11.10", "a903f5227417bd2a08c8a00a0cbcc458118be84480955e8d251297a425723f83", [:mix, :rebar3], [], "hexpm", "0d6cd36ff8ba174db29148fc112b5842186b68a90ce9fc2b3ec3afe76593e614"},
-  "jsx": {:hex, :jsx, "2.8.3", "a05252d381885240744d955fbe3cf810504eb2567164824e19303ea59eef62cf", [:mix, :rebar3], [], "hexpm", "fc3499fed7a726995aa659143a248534adc754ebd16ccd437cd93b649a95091f"},
-  "meck": {:hex, :meck, "1.0.0", "24676cb6ee6951530093a93edcd410cfe4cb59fe89444b875d35c9d3909a15d0", [:rebar3], [], "hexpm", "680a9bcfe52764350beb9fb0335fb75fee8e7329821416cee0a19fec35433882"},
   "mime": {:hex, :mime, "2.0.7", "b8d739037be7cd402aee1ba0306edfdef982687ee7e9859bee6198c1e7e2f128", [:mix], [], "hexpm", "6171188e399ee16023ffc5b76ce445eb6d9672e2e241d2df6050f3c771e80ccd"},
   "mimic": {:hex, :mimic, "1.12.0", "34c9d1fb8e756df09ca5f96861d273f2bb01063df1a6a51a4c101f9ad7f07a9c", [:mix], [{:ham, "~> 0.2", [hex: :ham, repo: "hexpm", optional: false]}], "hexpm", "eaa43d495d6f3bc8099b28886e05a1b09a2a6be083f6385c3abc17599e5e2c43"},
   "mint": {:hex, :mint, "1.7.1", "113fdb2b2f3b59e47c7955971854641c61f378549d73e829e1768de90fc1abf1", [:mix], [{:castore, "~> 0.1.0 or ~> 1.0", [hex: :castore, repo: "hexpm", optional: true]}, {:hpax, "~> 0.1.1 or ~> 0.2.0 or ~> 1.0", [hex: :hpax, repo: "hexpm", optional: false]}], "hexpm", "fceba0a4d0f24301ddee3024ae116df1c3f4bb7a563a731f45fdfeb9d39a231b"},

test/peek_app_sdk/metrics_test.exs

@@ -0,0 +1,122 @@
+defmodule PeekAppSDK.MetricsTest do
+  use ExUnit.Case, async: false
+
+  alias PeekAppSDK.Metrics
+
+  describe "track_install/4" do
+    test "delegates to PeekAppSDK.Metrics.Client.track_install/4" do
+      external_refid = "partner-123"
+      name = "Partner Name"
+      is_test = false
+      opts = [post_message: true]
+
+      Tesla.Adapter.Finch
+      |> Mimic.stub(:call, fn env, _opts ->
+        assert env.method == :post
+
+        payload = Jason.decode!(env.body)
+        assert payload["eventId"] == "app.install"
+        assert payload["anonymousId"] == external_refid
+        assert payload["usageDetails"] == name
+        assert payload["customFields"]["partnerIsTest"] == is_test
+
+        {:ok, %Tesla.Env{status: 202}}
+      end)
+
+      assert {:ok, _} = Metrics.track_install(external_refid, name, is_test, opts)
+    end
+
+    test "delegates to PeekAppSDK.Metrics.Client.track_install/3 with default opts" do
+      external_refid = "partner-456"
+      name = "Another Partner"
+      is_test = true
+
+      Tesla.Adapter.Finch
+      |> Mimic.stub(:call, fn env, _opts ->
+        assert env.method == :post
+
+        payload = Jason.decode!(env.body)
+        assert payload["eventId"] == "app.install"
+        assert payload["anonymousId"] == external_refid
+        assert payload["usageDetails"] == name
+        assert payload["customFields"]["partnerIsTest"] == is_test
+
+        {:ok, %Tesla.Env{status: 202}}
+      end)
+
+      assert {:ok, _} = Metrics.track_install(external_refid, name, is_test)
+    end
+  end
+
+  describe "track_uninstall/4" do
+    test "delegates to PeekAppSDK.Metrics.Client.track_uninstall/4" do
+      external_refid = "partner-789"
+      name = "Test Partner"
+      is_test = false
+      opts = [post_message: true]
+
+      Tesla.Adapter.Finch
+      |> Mimic.stub(:call, fn env, _opts ->
+        assert env.method == :post
+
+        payload = Jason.decode!(env.body)
+        assert payload["eventId"] == "app.uninstall"
+        assert payload["anonymousId"] == external_refid
+        assert payload["usageDetails"] == name
+        assert payload["customFields"]["partnerIsTest"] == is_test
+
+        {:ok, %Tesla.Env{status: 202}}
+      end)
+
+      assert {:ok, _} = Metrics.track_uninstall(external_refid, name, is_test, opts)
+    end
+
+    test "delegates to PeekAppSDK.Metrics.Client.track_uninstall/3 with default opts" do
+      external_refid = "partner-101"
+      name = "Final Partner"
+      is_test = true
+
+      Tesla.Adapter.Finch
+      |> Mimic.stub(:call, fn env, _opts ->
+        assert env.method == :post
+
+        payload = Jason.decode!(env.body)
+        assert payload["eventId"] == "app.uninstall"
+        assert payload["anonymousId"] == external_refid
+        assert payload["usageDetails"] == name
+        assert payload["customFields"]["partnerIsTest"] == is_test
+
+        {:ok, %Tesla.Env{status: 202}}
+      end)
+
+      assert {:ok, _} = Metrics.track_uninstall(external_refid, name, is_test)
+    end
+  end
+
+  describe "track/2" do
+    test "delegates to PeekAppSDK.Metrics.Client.track/2" do
+      event_id = "custom.event"
+
+      payload = %{
+        anonymousId: "user-123",
+        level: "info",
+        customField: "test value"
+      }
+
+      Tesla.Adapter.Finch
+      |> Mimic.stub(:call, fn env, _opts ->
+        assert env.method == :post
+
+        sent_payload = Jason.decode!(env.body)
+        assert sent_payload["eventId"] == event_id
+        assert sent_payload["anonymousId"] == "user-123"
+        assert sent_payload["level"] == "info"
+        assert sent_payload["customField"] == "test value"
+
+        {:ok, %Tesla.Env{status: 202}}
+      end)
+
+      assert {:ok, _} = Metrics.track(event_id, payload)
+    end
+  end
+end