fix: redundant events for toggle button

Author: coladarci

CHANGELOG.md

@@ -13,6 +13,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
   - Follows the same pattern as Phoenix core input components for consistency
   - Maintains 100% backward compatibility - existing usage without labels continues to work unchanged
 
+
+### Fixed
+- Toggle button no longer emits an event when clicking the already-selected option, preventing redundant LiveView events in both standalone and form-integrated usage.
+
 ## [2025-11-07]
 
 ### Added

lib/peek_app_sdk/ui/odyssey/toggle_button.ex

@@ -94,7 +94,11 @@ defmodule PeekAppSDK.UI.Odyssey.ToggleButton do
         :for={{option, index} <- Enum.with_index(@options)}
         type="button"
         value={to_string(option_value(option))}
-        phx-click={@on_change}
+        phx-click={
+          if to_string(@selected) == to_string(option_value(option)),
+            do: nil,
+            else: @on_change
+        }
         phx-target={@phx_target}
         class={
           [

test/peek_app_sdk/ui/odyssey_test.exs

@@ -28,6 +28,18 @@ defmodule PeekAppSDK.UI.OdysseyTest do
       assert html =~ "bg-gray-50 text-blue-600"
     end
 
+    test "does not attach phx-click for selected option" do
+      html =
+        render_component(&PeekAppSDK.UI.Odyssey.odyssey_toggle_button/1, %{
+          options: ["Minutes", "Hours", "Days"],
+          selected: "Hours",
+          on_change: "change_time_unit"
+        })
+
+      refute html =~ ~r/value="Hours"[^>]*phx-click=/
+      assert html =~ ~r/value="Minutes"[^>]*phx-click="change_time_unit"/
+    end
+
     test "shows unselected options with gray styling" do
       html =
         render_component(&PeekAppSDK.UI.Odyssey.odyssey_toggle_button/1, %{
@@ -70,7 +82,9 @@ defmodule PeekAppSDK.UI.OdysseyTest do
       assert html =~ "Phone Call"
       assert html =~ "hero-phone"
       # Should have the selected button highlighted (email)
-      assert html =~ ~r/value="email"[^>]*phx-click="change_channel"/
+      # Selected option should not include a click handler; unselected should
+      refute html =~ ~r/value="email"[^>]*phx-click=/
+      assert html =~ ~r/value="sms"[^>]*phx-click="change_channel"/
     end
 
     test "automatically integrates with form fields when field is provided" do