Merge pull request #210 from pegasystems/bugfix/prval

fix: enhance accessibility checks in test runner with error handling …

Author: ricmars

.github/workflows/validatepr.yaml

@@ -50,4 +50,4 @@ jobs:
           curl -vvvv http://localhost:6006/index.html
           cat log.txt
       - name: Run tests
-        run: npm run test-storybook
+        run: npm run test-storybook -- --maxWorkers=1 --verbose

.storybook/test-runner.ts

@@ -11,21 +11,41 @@ const config: TestRunnerConfig = {
   async preVisit(page) {
     await injectAxe(page);
   },
+
   async postVisit(page, context) {
-    // Get the entire context of a story, including parameters, args, argTypes, etc.
-    const storyContext = await getStoryContext(page, context);
+    try {
+      // Get the entire context of a story, including parameters, args, argTypes, etc.
+      const storyContext = await getStoryContext(page, context);
+
+      // Apply story-level a11y rules
+      await configureAxe(page, {
+        rules: storyContext.parameters?.a11y?.config?.rules,
+      });
 
-    // Apply story-level a11y rules
-    await configureAxe(page, {
-      rules: storyContext.parameters?.a11y?.config?.rules,
-    });
+      // Wait a bit to ensure any previous Axe runs have completed
+      await page.waitForTimeout(200);
 
-    await checkA11y(page, '#storybook-root', {
-      detailedReport: true,
-      detailedReportOptions: {
-        html: true,
-      },
-    });
+      await checkA11y(page, '#storybook-root', {
+        detailedReport: true,
+        detailedReportOptions: {
+          html: true,
+        },
+      });
+    } catch (error) {
+      // If Axe is already running, wait and retry once
+      if (error instanceof Error && error.message.includes('Axe is already running')) {
+        console.warn('Axe was already running, waiting and retrying...');
+        await page.waitForTimeout(1000); // Increased wait time
+        await checkA11y(page, '#storybook-root', {
+          detailedReport: true,
+          detailedReportOptions: {
+            html: true,
+          },
+        });
+      } else {
+        throw error;
+      }
+    }
   },
 };
 

src/components/Pega_Extensions_DisplayPDF/demo.stories.tsx

@@ -24,28 +24,44 @@ export default {
   component: PegaExtensionsDisplayPDF,
 };
 
-const blob2base64 = (blob: Blob, mimeType: string) => {
+const blob2base64 = (blob: Blob) => {
   return new Promise((resolve, reject) => {
     const reader = new FileReader();
     reader.onloadend = () => {
-      const dataUrlPrefix = `data:${mimeType};base64,`;
-      const base64WithDataUrlPrefix = reader.result;
-      const base64 =
-        typeof base64WithDataUrlPrefix === 'string' ? base64WithDataUrlPrefix.replace(dataUrlPrefix, '') : '';
-      resolve(base64);
+      const result = reader.result;
+      if (typeof result === 'string') {
+        // Remove the data URL prefix to get just the base64 string
+        const base64 = result.split(',')[1];
+        console.log('Base64 length:', base64?.length);
+        resolve(base64 || '');
+      } else {
+        reject(new Error('Failed to read blob as data URL'));
+      }
     };
     reader.onerror = reject;
     reader.readAsDataURL(blob);
   });
 };
 
 const getBinary = async () => {
-  const response = await fetch('./SamplePDF.pdf');
-  if (response.blob) {
-    const blob = await response.blob();
-    return blob2base64(blob, 'application/pdf');
+  try {
+    const response = await fetch('/SamplePDF.pdf');
+    console.log('PDF fetch response status:', response.status);
+    console.log('PDF fetch response ok:', response.ok);
+
+    if (response.ok && response.blob) {
+      const blob = await response.blob();
+      console.log('PDF blob size:', blob.size);
+      return blob2base64(blob);
+    }
+    console.warn('PDF fetch failed or no blob available');
+    // Fallback to a minimal valid PDF for testing
+    return 'JVBERi0xLjQKJcOkw7zDtsO8CjIgMCBvYmoKPDwKL0xlbmd0aCAzIDAgUgovVHlwZSAvUGFnZQo+PgpzdHJlYW0KZW5kb2JqCjMgMCBvYmoKMTEKZW5kb2JqCjEgMCBvYmoKPDwKL1R5cGUgL1BhZ2VzCi9LaWRzIFsyIDAgUl0KL0NvdW50IDEKL01lZGlhQm94IFswIDAgNTk1IDg0Ml0KPj4KZW5kb2JqCjQgMCBvYmoKPDwKL1R5cGUgL0NhdGFsb2cKL1BhZ2VzIDEgMCBSCj4+CmVuZG9iagp4cmVmCjAgNQowMDAwMDAwMDAwIDY1NTM1IGYKMDAwMDAwMDAwOSAwMDAwMCBuCjAwMDAwMDAwNTggMDAwMDAgbgowMDAwMDAwMTE1IDAwMDAwIG4KMDAwMDAwMDM3OCAwMDAwMCBuCnRyYWlsZXIKPDwKL1NpemUgNQovUm9vdCA0IDAgUgo+PgpzdGFydHhyZWYKNDk3CiUlRU9G';
+  } catch (error) {
+    console.error('PDF fetch error:', error);
+    // Fallback to a minimal valid PDF for testing
+    return 'JVBERi0xLjQKJcOkw7zDtsO8CjIgMCBvYmoKPDwKL0xlbmd0aCAzIDAgUgovVHlwZSAvUGFnZQo+PgpzdHJlYW0KZW5kb2JqCjMgMCBvYmoKMTEKZW5kb2JqCjEgMCBvYmoKPDwKL1R5cGUgL1BhZ2VzCi9LaWRzIFsyIDAgUl0KL0NvdW50IDEKL01lZGlhQm94IFswIDAgNTk1IDg0Ml0KPj4KZW5kb2JqCjQgMCBvYmoKPDwKL1R5cGUgL0NhdGFsb2cKL1BhZ2VzIDEgMCBSCj4+CmVuZG9iagp4cmVmCjAgNQowMDAwMDAwMDAwIDY1NTM1IGYKMDAwMDAwMDAwOSAwMDAwMCBuCjAwMDAwMDAwNTggMDAwMDAgbgowMDAwMDAwMTE1IDAwMDAwIG4KMDAwMDAwMDM3OCAwMDAwMCBuCnRyYWlsZXIKPDwKL1NpemUgNQovUm9vdCA0IDAgUgo+PgpzdGFydHhyZWYKNDk3CiUlRU9G';
   }
-  return '';
 };
 
 const setPCore = (url: string) => {