Fix #4

Fixed The Problem of old AppImage not being removed when updating.

The main problem was in the line 182, which caused to return repo name instead of file path.

Author: pegvin

src/commands/update.go

@@ -30,7 +30,11 @@ func (cmd *UpdateCmd) Run() (err error) {
 	}
 
 	if len(cmd.Targets) == 0 {
-		fmt.Println("No Application Installed")
+		if cmd.All {
+			fmt.Println("No Application Installed")
+		} else {
+			fmt.Println("No Application Specified To Update")
+		}
 		return nil
 	}
 
@@ -100,20 +104,32 @@ func (cmd *UpdateCmd) Run() (err error) {
 			return err
 		}
 
-		registry, err := utils.OpenRegistry()
-		registry.Remove(entry.FilePath) // Remove old file from registry
+		// Integrated The AppImage To Desktop
+		err = utils.CreateDesktopIntegration(targetFilePath)
+		if err != nil {
+			os.Remove(targetFilePath)
+			return err
+		}
 
+		registry, err := utils.OpenRegistry()
 		if err != nil {
 			return err
 		}
 
-		// Integrated The AppImage To Desktop
-		err = utils.CreateDesktopIntegration(targetFilePath)
+		// De-Integrate old app from desktop
+		err = utils.RemoveDesktopIntegration(entry.FilePath)
 		if err != nil {
-			os.Remove(targetFilePath)
+			os.Remove(targetFilePath) // If error, remove the newly downloaded appimage.
 			return err
+		} else {
+			err = os.Remove(entry.FilePath) // Remove the old appimage
+			if err != nil {
+				fmt.Println("Cannot Remove The Old AppImage.\n", err.Error())
+			}
 		}
 
+		registry.Remove(entry.FilePath) // Remove Old File From Registry
+
 		sha1hash, _ := utils.GetFileSHA1(targetFilePath)
 		appImageInfo, _ := utils.GetAppImageInfo(targetFilePath)
 		err = registry.Add(utils.RegistryEntry{
@@ -129,14 +145,6 @@ func (cmd *UpdateCmd) Run() (err error) {
 			return err
 		}
 
-		// De-Integrate old app from desktop
-		err = utils.RemoveDesktopIntegration(entry.FilePath)
-		if err != nil {
-			os.Remove(targetFilePath)
-			return err
-		}
-
-		registry.Remove(entry.FilePath)
 		err = registry.Close()
 		if err != nil {
 			return err
@@ -179,7 +187,6 @@ func (cmd *UpdateCmd) getRegistryEntry(target string) (utils.RegistryEntry, erro
 	defer registry.Close()
 
 	entry, _ := registry.Lookup(target)
-	entry.FilePath = target
 
 	return entry, nil
 }