Skip to content

Reconsider default value for PELIAS_CONFIG environment var #15

Open
@orangejulius

Description

Right now, the baseimage sets the PELIAS_CONFIG environment variable to /code/pelias.json.

ENV PELIAS_CONFIG '/code/pelias.json'
RUN echo '{}' > '/code/pelias.json'

However, because the underlying code in our service and importer docker images will also end up in /code, and we generally will override pelias.json by mounting a volume into the Docker image, this is not a good location for pelias.json to live.

If a user tried to mount a volume to /code, it would end up overwriting all the Pelias code and break everything. So essentially, even though this default is set, it will always have to be overridden in order to be useful.

Is there any value in even setting a default value for PELIAS_CONFIG?

If there isn't we can simplify everything by not setting it at all.

If there is, could we make it point to a separate directory that can easily be overwritten by a mounted Docker volume? Maybe /config/pelias.json? This would be nice and would set up a clear separation between code, configuration, and data.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or requestquestionFurther information is requested

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions