Description
Right now, the baseimage sets the PELIAS_CONFIG
environment variable to /code/pelias.json
.
Lines 39 to 40 in 61e97e5
However, because the underlying code in our service and importer docker images will also end up in /code
, and we generally will override pelias.json
by mounting a volume into the Docker image, this is not a good location for pelias.json
to live.
If a user tried to mount a volume to /code
, it would end up overwriting all the Pelias code and break everything. So essentially, even though this default is set, it will always have to be overridden in order to be useful.
Is there any value in even setting a default value for PELIAS_CONFIG
?
If there isn't we can simplify everything by not setting it at all.
If there is, could we make it point to a separate directory that can easily be overwritten by a mounted Docker volume? Maybe /config/pelias.json
? This would be nice and would set up a clear separation between code, configuration, and data.
Activity