Skip to content

venue_classification: investigate change #151

Open
@missinglink

Description

Today we are merging pelias/api#1565 which brings a bunch of pelias/parser changes into pelias/api.

As part of this process we did some wider acceptance test checks and diff'd them against the current baseline.

One change which was identified was this query (at partial completion "San Simeon Drive Desert Hot Spr") which identifies the incomplete spr token as a street.

San Simeon Drive Desert Hot Springs CA 92240 {"focus.point.lat":33.96112,"focus.point.lon":-116.50168}
-FFFFF0000000000000000000000000000000000FFF00
+FFFFF0000000000000000000000000F00000000FFF00

Running a git bisect shows that this change was introduced in a65218d

A simple change to the en/street_types.txt file seems to resolve the issue, but it's unclear why this issue didn't exist previously.

diff --git a/resources/pelias/dictionaries/libpostal/en/street_types.txt b/resources/pelias/dictionaries/libpostal/en/street_types.txt
index 30ecf9d..9fbdcbe 100644
--- a/resources/pelias/dictionaries/libpostal/en/street_types.txt
+++ b/resources/pelias/dictionaries/libpostal/en/street_types.txt
@@ -14,3 +14,5 @@ beltway
 !broadway|bdwy|bway|bwy|brdway
 !esplanade|esp|espl
 market
+
+!spr

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions