Merge pull request #9 from pelican-plugins/avoid-critical-error-when-img-has-no-src

Avoid a CRITICAL error in case of <img> without src attribute

Author: justinmayer

pelican/plugins/featured_image/featured_image.py

@@ -32,7 +32,7 @@ def images_extraction(instance):
         if not featured_image:
             soup = BeautifulSoup(instance._content, "html.parser")
             imageTag = soup.find("img")
-            if imageTag:
+            if imageTag and imageTag.get("src"):
                 featured_image = imageTag["src"]
 
         # Set the attribute to content instance

pelican/plugins/featured_image/test_featured_image.py

@@ -41,6 +41,22 @@ def test_extract_image_from_content(self):
         featured_image.images_extraction(article)
         self.assertEqual(article.featured_image, TEST_CONTENT_IMAGE_URL)
 
+    def test_extract_image_from_content_and_img_has_no_src(self):
+        args = {
+            "content": (
+                str(generate_lorem_ipsum(n=3, html=True))
+                + "<img>"
+                + str(generate_lorem_ipsum(n=2, html=True))
+            ),
+            "metadata": {
+                "summary": TEST_SUMMARY_WITHOUTIMAGE,
+            },
+        }
+
+        article = Article(**args)
+        featured_image.images_extraction(article)
+        self.assertEqual(article.featured_image, None)
+
     def test_extract_image_from_summary(self):
         args = {
             "content": TEST_CONTENT,