Skip to content

Commit 78e9c94

Browse files
committed
Fixing tests
1 parent 7b980c2 commit 78e9c94

File tree

2 files changed

+8
-6
lines changed

2 files changed

+8
-6
lines changed

image_preview_thumbnailer.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,9 @@ def process_link(img_downloader, anchor_tag, url_match, config=PluginConfig()):
150150
tmp_thumb_filepath = img_downloader(url_match, config)
151151
if not tmp_thumb_filepath: # => means the downloader failed to retrieve the image in a "supported" case
152152
hostname = urlparse(anchor_tag['href']).netloc
153-
with open(config.fs_thumbs_dir(f'{thumb_filename}.{hostname}.none'), 'w', encoding='utf8'):
153+
none_filename = f'{thumb_filename}.{hostname}.none'
154+
LOGGER.info("Downloader could not retrieve image: now creating %s", none_filename)
155+
with open(config.fs_thumbs_dir(none_filename), 'w', encoding='utf8'):
154156
pass
155157
return
156158
img_ext = os.path.splitext(tmp_thumb_filepath)[1]

test_image_preview_thumbnailer.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
</html>"""
1919

2020

21-
def setup():
21+
def setup_function():
2222
logging.root.setLevel(logging.DEBUG)
2323
LOGGER.disable_filter() # disabling LimitFilter log deduping from pelican.log.FatalLogger
2424
thumbs_dir = PluginConfig().fs_thumbs_dir()
@@ -37,10 +37,10 @@ def test_artstation():
3737

3838
@pytest.mark.integration
3939
def test_behance():
40-
url = 'https://www.behance.net/gallery/58149803/Character-design-vol-8'
40+
url = 'https://www.behance.net/gallery/26813509/everydays-may-2015'
4141
out_html = process_all_links_in_html(BLOG_PAGE_TEMPLATE.format(illustration_url=url))
42-
assert os.path.getsize("thumbnails/Character-design-vol-8.jpg") > 0
43-
assert 'src="thumbnails/Character-design-vol-8.jpg"' in out_html
42+
assert os.path.getsize("thumbnails/everydays-may-2015.jpg") > 0
43+
assert 'src="thumbnails/everydays-may-2015.jpg"' in out_html
4444

4545
@pytest.mark.integration
4646
def test_dafont():
@@ -60,7 +60,7 @@ def test_deviantart():
6060
def test_deviantart_mature_content():
6161
url = 'https://www.deviantart.com/eggboy122/art/Angel-maybe-697980132'
6262
out_html = process_all_links_in_html(BLOG_PAGE_TEMPLATE.format(illustration_url=url))
63-
assert os.path.getsize("thumbnails/Angel-maybe-697980132.none") == 0
63+
assert os.path.getsize("thumbnails/Angel-maybe-697980132.www.deviantart.com.none") == 0
6464
assert '<img' not in out_html
6565

6666
@pytest.mark.integration

0 commit comments

Comments
 (0)