Construct fragment via fragment[].

This change makes the fragment consistent with elements by using
__getitem__ to specify child nodes.

See #93 for discussion.

Author: pelme

docs/changelog.md

@@ -1,8 +1,9 @@
 # Changelog
 
 ## Next (minor)
-- Add a `Fragment` node for explicitly grouping a collection of nodes. Fixes
-[#82](https://github.com/pelme/htpy/issues/82)
+- Add `fragment` for explicitly grouping a collection of nodes. Fixes
+[issue #82](https://github.com/pelme/htpy/issues/82).
+See [PR #86](https://github.com/pelme/htpy/pull/86) and [PR #95](https://github.com/pelme/htpy/pull/95). Thanks to [Thomas Scholtes (@geigerzaehler)](https://github.com/geigerzaehler).
 
 ## 25.2.0 - 2025-02-01
 - Context providers longer require wrapping nodes in a function/lambda. This

docs/usage.md

@@ -98,8 +98,8 @@ Fragments allow you to wrap a group of nodes (not necessarily elements) so that
 they can be rendered without a wrapping element.
 
 ```pycon
->>> from htpy import p, i, Fragment
->>> content = Fragment("Hello ", None, i["world!"])
+>>> from htpy import p, i, fragment
+>>> content = fragment["Hello ", None, i["world!"]]
 >>> print(content)
 Hello <i>world!</i>
 
@@ -404,8 +404,8 @@ Just like [render_node()](#render-elements-without-a-parent-orphans), there is
 without a parent:
 
 ```pycon
->>> from htpy import li, iter_node
->>> for chunk in iter_node([li["a"], li["b"]]):
+>>> from htpy import li, Fragment
+>>> for chunk in fragment[li["a"], li["b"]]:
 ...     print(f"got a chunk: {chunk!r}")
 ...
 got a chunk: '<li>'

htpy/__init__.py

@@ -197,8 +197,7 @@ def _iter_node_context(x: Node, context_dict: dict[Context[t.Any], t.Any]) -> It
             )
         yield from _iter_node_context(x.func(context_value), context_dict)
     elif isinstance(x, Fragment):
-        for node in x._nodes:  # pyright: ignore [reportPrivateUsage]
-            yield from _iter_node_context(node, context_dict)
+        yield from _iter_node_context(x._node, context_dict)  # pyright: ignore
     elif isinstance(x, str | _HasHtml):
         yield str(_escape(x))
     elif isinstance(x, int):
@@ -348,17 +347,15 @@ def __repr__(self) -> str:
 
 
 class Fragment:
-    """A collection of nodes without a wrapping element.
+    """A collection of nodes without a wrapping element."""
 
-    >>> content = Fragment("Hello ", None, i["world!"])
-    >>> print(content)
-    Hello <i>world!</i>
-    """
+    __slots__ = ("_node",)
 
-    __slots__ = ("_nodes",)
-
-    def __init__(self, *nodes: Node) -> None:
-        self._nodes = nodes
+    def __init__(self) -> None:
+        # Make it awkward to instantiate a Fragment directly:
+        # Encourage using fragment[x]. That is why it is not possible to set the
+        # node directly via the constructor.
+        self._node: Node = None
 
     def __iter__(self) -> Iterator[str]:
         return iter_node(self)
@@ -369,13 +366,23 @@ def __str__(self) -> str:
     __html__ = __str__
 
 
+class _FragmentGetter:
+    def __getitem__(self, node: Node) -> Fragment:
+        result = Fragment()
+        result._node = node  # pyright: ignore[reportPrivateUsage]
+        return result
+
+
+fragment = _FragmentGetter()
+
+
 def render_node(node: Node) -> _Markup:
     return _Markup("".join(iter_node(node)))
 
 
 def comment(text: str) -> Fragment:
     escaped_text = text.replace("--", "")
-    return Fragment(_Markup(f"<!-- {escaped_text} -->"))
+    return fragment[_Markup(f"<!-- {escaped_text} -->")]
 
 
 @t.runtime_checkable

tests/test_context.py

@@ -5,7 +5,7 @@
 import markupsafe
 import pytest
 
-from htpy import Context, Fragment, Node, div
+from htpy import Context, Node, div, fragment
 
 if t.TYPE_CHECKING:
     from .conftest import RenderFixture
@@ -116,6 +116,6 @@ def test_context_passed_via_fragment(render: RenderFixture) -> None:
     def echo(value: str) -> str:
         return value
 
-    result = div[ctx.provider("foo", Fragment(echo()))]
+    result = div[ctx.provider("foo", fragment[echo()])]
 
     assert render(result) == ["<div>", "foo", "</div>"]

tests/test_fragment.py

@@ -1,16 +1,16 @@
 import markupsafe
 
-from htpy import Fragment, i, p
+from htpy import fragment, i, p
 
 from .conftest import RenderFixture
 
 
 def test_render_direct() -> None:
-    assert str(Fragment("Hello ", None, i["World"])) == "Hello <i>World</i>"
+    assert str(fragment["Hello ", None, i["World"]]) == "Hello <i>World</i>"
 
 
 def test_render_as_child(render: RenderFixture) -> None:
-    assert render(p["Say: ", Fragment("Hello ", None, i["World"]), "!"]) == [
+    assert render(p["Say: ", fragment["Hello ", None, i["World"]], "!"]) == [
         "<p>",
         "Say: ",
         "Hello ",
@@ -23,11 +23,11 @@ def test_render_as_child(render: RenderFixture) -> None:
 
 
 def test_render_nested(render: RenderFixture) -> None:
-    assert render(Fragment(Fragment("Hel", "lo "), "World")) == ["Hel", "lo ", "World"]
+    assert render(fragment[fragment["Hel", "lo "], "World"]) == ["Hel", "lo ", "World"]
 
 
 def test_render_chunks(render: RenderFixture) -> None:
-    assert render(Fragment("Hello ", None, i["World"])) == [
+    assert render(fragment["Hello ", None, i["World"]]) == [
         "Hello ",
         "<i>",
         "World",
@@ -36,8 +36,8 @@ def test_render_chunks(render: RenderFixture) -> None:
 
 
 def test_safe() -> None:
-    assert markupsafe.escape(Fragment(i["hi"])) == "<i>hi</i>"
+    assert markupsafe.escape(fragment[i["hi"]]) == "<i>hi</i>"
 
 
 def test_iter() -> None:
-    assert list(Fragment("Hello ", None, i["World"])) == ["Hello ", "<i>", "World", "</i>"]
+    assert list(fragment["Hello ", None, i["World"]]) == ["Hello ", "<i>", "World", "</i>"]