Merge pull request #20 from jfrojo/patch-1

penglongli · web-flow · commit 8f239af416a0 · 2021-12-20T17:30:16.000+08:00
Bugfix: Error on custom metric creation
diff --git a/ginmetrics/types.go b/ginmetrics/types.go
@@ -111,6 +111,7 @@ func (m *Monitor) AddMetric(metric *Metric) error {
 		if err := f(metric); err == nil {
 			prometheus.MustRegister(metric.vec)
 			m.metrics[metric.Name] = metric
+			return nil
 		}
 	}
 	return errors.Errorf("metric type '%d' not existed.", metric.Type)

Original file line number	Diff line number	Diff line change
`@@ -111,6 +111,7 @@ func (m Monitor) AddMetric(metric Metric) error {`
`111`	`111`	`if err := f(metric); err == nil {`
`112`	`112`	`prometheus.MustRegister(metric.vec)`
`113`	`113`	`m.metrics[metric.Name] = metric`
	`114`	`+ return nil`
`114`	`115`	`}`
`115`	`116`	`}`
`116`	`117`	`return errors.Errorf("metric type '%d' not existed.", metric.Type)`