lint

el-agua · el-agua · commit 7770b77e2c4c · 2026-04-08T02:51:02.000-04:00
diff --git a/backend/degree/views.py b/backend/degree/views.py
@@ -264,7 +264,8 @@ def switch_rule(self, request, *args, **kwargs):
         if target_rule not in rule_to_degree:
             raise ValidationError({"rule_id": "Rule does not belong to this degree plan."})
 
-        if not target_rule.check_belongs(full_code) and target_rule not in fulfillment.overrides.all():
+        is_overridden = target_rule in fulfillment.overrides.all()
+        if not target_rule.check_belongs(full_code) and not is_overridden:
             raise ValidationError(
                 {"rule_id": f"Course {full_code} does not satisfy rule {target_rule.id}"}
             )

Original file line number	Diff line number	Diff line change
`@@ -264,7 +264,8 @@ def switch_rule(self, request, args, *kwargs):`
`264`	`264`	`if target_rule not in rule_to_degree:`
`265`	`265`	`raise ValidationError({"rule_id": "Rule does not belong to this degree plan."})`
`266`	`266`
`267`		`- if not target_rule.check_belongs(full_code) and target_rule not in fulfillment.overrides.all():`
	`267`	`+ is_overridden = target_rule in fulfillment.overrides.all()`
	`268`	`+ if not target_rule.check_belongs(full_code) and not is_overridden:`
`268`	`269`	`raise ValidationError(`
`269`	`270`	`{"rule_id": f"Course {full_code} does not satisfy rule {target_rule.id}"}`
`270`	`271`	`)`