Solving 500 error when deleting item

Author: LautaroJBeck

backend/market/views.py

@@ -332,7 +332,7 @@ def destroy(self, request, *args, **kwargs):
         obj = get_object_or_404(queryset, **filter)
         self.check_object_permissions(self.request, obj)
         self.perform_destroy(obj)
-        return Response({"deleted": True}, status=status.HTTP_204_NO_CONTENT)
+        return Response(status=status.HTTP_204_NO_CONTENT)
 
     def list(self, request, *args, **kwargs):
         if not Listing.objects.filter(pk=int(self.kwargs["listing_id"])).exists():

frontend/components/listings/detail/ListingDetail.tsx

@@ -381,9 +381,8 @@ export const ListingDetail = ({
     if (isDeleting) return;
     setIsDeleting(true);
     try {
-      const res = await deleteListing(listingState.id);
-      console.log(res);
-      window.location.href = "/";
+      await deleteListing(listingState.id);
+      window.location.href = "/items";
     } catch (err) {
       console.log(err);
       setIsDeleting(false);

frontend/lib/actions.ts

@@ -99,6 +99,9 @@ async function serverFetch<T>(endpoint: string, options: RequestInit = {}): Prom
     throw new APIError(errorMessage, response.status);
   }
 
+  if (response.status === 204 || response.status === 205) {
+    return undefined as T;
+  }
   return response.json();
 }
 
@@ -313,8 +316,8 @@ export async function updateListing(
   });
 }
 
-export async function deleteListing(listingId: number): Promise<Listing> {
-  return await serverFetch<Listing>(`/market/listings/${listingId}/`, {
+export async function deleteListing(listingId: number): Promise<void> {
+  await serverFetch<void>(`/market/listings/${listingId}/`, {
     method: "DELETE",
   });
 }